1625559 - Minor BlockReflowInput cleanup

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I notice some cleanup for BlockReflowInput while learning how a block frame setup the content area to reflow its children.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1625559 Part 1 - Remove two unused BlockReflowInput flags.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1625559 Part 2 - Use BlockReflowInput::ContentBEnd() to replace undocumented mBEndEdge.

ContentBEnd() is equivalent to mBEndEdge except when ContentBSize() is
unconstrained because ContentBEnd() can overflow. However, according to
ContentBEnd()'s documentation, the user shouldn't use ContentBEnd() when
ContentBSize() is constrained, so I add an assertion in ContentBEnd() as
a reminder.

Depends on D68623

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4457ff1ca67
Part 1 - Remove two unused BlockReflowInput flags. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/b1016f5d41b6
Part 2 - Use BlockReflowInput::ContentBEnd() to replace undocumented mBEndEdge. r=jfkthame

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c4457ff1ca67
https://hg.mozilla.org/mozilla-central/rev/b1016f5d41b6