Closed Bug 1625559 Opened 5 years ago Closed 5 years ago

Minor BlockReflowInput cleanup

Categories

(Core :: Layout, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(2 files)

I notice some cleanup for BlockReflowInput while learning how a block frame setup the content area to reflow its children.

ContentBEnd() is equivalent to mBEndEdge except when ContentBSize() is
unconstrained because ContentBEnd() can overflow. However, according to
ContentBEnd()'s documentation, the user shouldn't use ContentBEnd() when
ContentBSize() is constrained, so I add an assertion in ContentBEnd() as
a reminder.

Depends on D68623

Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c4457ff1ca67 Part 1 - Remove two unused BlockReflowInput flags. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/b1016f5d41b6 Part 2 - Use BlockReflowInput::ContentBEnd() to replace undocumented mBEndEdge. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: