1625576 - First-run wizard dialog does not close after clicking "Advanced config"

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect, P3)

Description

[Paul Morris [:pmorris]]

Steps to reproduce:

• With a new profile, open Thunderbird and start setting up a new email account in the first-run wizard.
• Click the "Advanced config" link.

Then the "Set up your existing email address" dialog stays on-screen, obscuring the "Account Settings" in a tab behind it. I think it should close when you click "Advanced config".

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1625576-emailwizard-regression.diff

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9136453 [details] [diff] [review]
1625576-emailwizard-regression.diff

Review of attachment 9136453 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  I applied the patch and went through the steps to reproduce and the problem did not occur.  Also, after clicking "Advanced config" the "System integration" dialog immediately appeared.  After dismissing that the gmail oauth account login dialog appeared.  That seems like reasonable behavior to me, even though it delays you from getting to the "advanced config" step.  Just wanted to note it in case it's not what we want.  In any case I think this is good to land.

Comment 3

[Alessandro Castellani [:aleca]]

Yes, that's the expected behavior for the system integration dialog as it should always be triggered as a callback when the initial setup gets dismissed on a clear installation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ab11dcf13e4
Close the emailWizard dialog when accessing the account settings during initial setup process. r=pmorris