1625724 - Consider backing out bug 680300

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: testcase.

As it doesn't patch the side channel completely, and per https://github.com/mozilla/standards-positions/issues/213#issuecomment-552008322 it has caused issues.

Trivial test-case attached.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

There are similar ways to detect this in other browsers via window.open or what not, and bug 1528305 and such adds yet another one for compat reasons.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'm confused about the patch... Reverting the main bit in nsDocShell.cpp doesn't make the test added in that same bug fail... Plus obviously before that bug we used to just silently fail and now we have an error page....

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ok, so DocumentChannel kinda fixed the throwing, but I can repro the bug with documentchannel disabled...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

So I guess we can only do that when enabling DocumentChannel everywhere (bug 1607984 + turning it on on android)

Comment 5

[Anne (:annevk)]

Emilio, is this bug still relevant? We should fix bug 1626068 I think and try to close the places where we continue to leak this information.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yes it is. Once DocumentChannel is on everywhere we can remove the hack, and it shouldn't be observable afaict.

Comment 7

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)