162573 - [FIX]Button elements do not align correctly vertically

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Jostein Huglen]

Button elements do not align vertically along the baseline of other text etc.

Let Mozilla render this:

<p>Test text <button>Button</button> <input type="submit" /> some more text.</p>

... and notice how the button element is not correctly aligned vertically,
unlike the input element.

This bug makes the use of button elements look very weird in Mozilla...

Comment 1

[Jostein Huglen]

This bug was previously reported as bug 58190, and was marked fixed in 2001.

I'm still seeing this bug however, both in Mozilla 1.0 and Mozilla build 2002081308.

I was hoping this bug could be fixed before Mozilla 1.1 gets released, since
it's afterall making Mozilla render basic HTML 4 incorrectly. I'd do it myself,
if I only had the expertise...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

Comment 3

[Boris Zbarsky [:bzbarsky]]

Not happening for 1.1 unless it's a crash fix, at this point.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Neither are truly baseline-to-baseline-aligned -- it's just the input is
'text-bottom' aligned, but the button is 'baseline' aligned and the baseline
knowledge doesn't to through the button.  The following patch would make the
bottoms of the controls line up, but they'll still be different sizes.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: make things a little more consistent

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 95273 [details] [diff] [review]
make things a little more consistent

r=bzbarsky.  The size issues will require lots of work (this is where I mention
XBL form controls and put the work off).

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 95273 [details] [diff] [review]
make things a little more consistent

sr=roc+moz

Comment 8

[Boris Zbarsky [:bzbarsky]]

missed alpha deadline.. will try to land in beta.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 126813 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

marking fixed; size issues live in bug 70251 and its dependencies already.