1625750 - Drop "Lightning/version" from SeaMonkey user agent string

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, task)

Description

[Frank-Rainer Grahl (:frg)]

We expose this in the prefs so this should go too.

+++ This bug was initially created as a clone of Bug #1624241 +++

I think we should just remove Lightning from the user agent string now that it's built in. Even if it were not, we should do so for privacy reasons, especially since it contains the "b1" or "a1" part of the version.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1625750-removelightningua-2532.patch

[Approval Request Comment]
Regression caused by (bug #): Backport Bug 1624241
User impact if declined: useless ui
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): trivial.
String changes made by this patch: Only removals. Can be taken to 2.53.2

Comment 2

[Ian Neal]

Comment on attachment 9136607 [details] [diff] [review]
1625750-removelightningua-2532.patch

[Triage Comment]
LGTM r/a=me
Is this planned for 2.53.2 or 2.53.3?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08c6fe72312c
Drop "Lightning/version" from SeaMonkey user agent string. r=IanN

Comment 4

[Dmitry Butskoy (:buc)]

A copy of the Lightning extension is placed in the user profile. Such a copy is not updated by a newer system one (at least under Linux).

IOW, after updating of the SeaMonkey package in a distro, the dropping of "Lightning/Version" might not take effect if the user's profile still has the old copy of the extension.

Disable/enable don't help, remove and reinstall can help, but user is compelled to play with *extensions.installedDistroAddon" in about:config ...
Specifying 5.8.1.1 instead of 5.8.1 does not help too.

The robast work-around is to specify lockPref("calendar.useragent.extra", ""); somewhere in the system defaults. This drops "Lightning/Version" as well, and affects old versions too.

Is it Linux-only issues?

Comment 5

[Frank-Rainer Grahl (:frg)]

A copy of the Lightning extension is placed in the user profile. Such a copy is not updated by a newer system one (at least under Linux).

I thought about it when doing the patch. I don't think this is true. The Lightning version is bound to the SeaMonkey version. If you upgrade SeaMonkey from 2.53.1 to 2.53.2 Lightning should upgrade. 2.53.2 ships with 5.8.2 and will reject 5.8.1 or any lower/higher version. The problem would only occur if you run an older unofficial 2.53.2 from Bill and upgrade to the official 2.53.2. His version is already at 2.53.3 and these are all patched. But might be a good idea to add it to the release notes wich then will be ignored as usual :)

What is left is the case where a user pref is set and the string is blank. No longer used so minimal dead weight. Something for a later migration step to remove.

Comment 6

[Dmitry Butskoy (:buc)]

(In reply to Frank-Rainer Grahl (:frg) from comment #5)

The Lightning version is bound to the SeaMonkey version. If you upgrade SeaMonkey from 2.53.1 to 2.53.2 Lightning should upgrade.
Just because of another SM "main" version?
2.53.2 ships with 5.8.2 and will reject 5.8.1 or any lower/higher version.
I've tested that a patched Lightning with a bit increased vesrion (5.8.1-->5.8.1.1) does not reject/overwrite the current 5.8.1 (but under the same SM-2.53.1)

Comment 7

[Frank-Rainer Grahl (:frg)]

I've tested that a patched Lightning with a bit increased vesrion (5.8.1-->5.8.1.1) does not reject/overwrite the current 5.8.1 (but under the same SM-2.53.1)

Yes this is correct or better this is currently the case. IanN is looking into it and if I find some time I too. Major version changes should be picked up but minor now. During install time with a changed version it will update 5.8.1 to 5.8.2.