1625864 - Non-linked html:a elements should not be exposed as links to VoiceOver.

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

STR:

1. With VoiceOver on, open data:text/html,<a>This might point to something in the future.</a>
2. Read it with VoiceOver.
   • Expected: VoiceOver reads "This might point to something in the future." as normal text.
   • Actual: It reads the text as a link.

This is a placeholder link which has no href and therefore is not linked. It is neither linked nor focusable and should be exposed as non-linked to VoiceOver. Even though the accessible object has a link role, NVDA treats it as normal text because it isn't focusable nor linked. We must tell VoiceOver to do the same or expose a different role/subrole for this. Safari correctly exposes this and the other examples 6 through 8 as text only, or makes VoiceOver treat them as such.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1625864 - Promisify state change events test. r?Jamie

We will probably be adding a lot to this. So let's make it nice to use.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1625864 - Fire state change event on LINKED change. r?Jamie,morgan

Also stop recreating any accessible that has href modified.

Depends on D71257

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1625864 - Rename mac link test. r?morgan

I want to generalize it for other link stuff. Need a separate commit or
it is not recognized as a move, and won't retain history. For some reason.

Depends on D71258

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1625864 - Expose unlinked a tags as AXGroup. r?morgan

This is the recommended role in the HTML Accessibility API Mappings draft[1].

Although Chrome and Safari just expose unlinked a tags as AXStaticText.
They also don't update the accessble if it gets an href. So while we
are doing this a bit differently, I think it is probably better. And VO is happy.

1. https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings

Depends on D71259

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20bcd150f92c
Promisify state change events test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0a4a66240a9f
Fire state change event on LINKED change. r=Jamie,morgan
https://hg.mozilla.org/integration/autoland/rev/cf3caf6f708c
Rename mac link test. r=morgan

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1625864) for causing mochitest failures in test_update.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=cf3caf6f708cfae3d18ab5d244e1a9b2e71d7be3&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64%2Fdebug-mochitest-a11y-1proc%2Cm-1proc%28a11y%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298478543&repo=autoland&lineNumber=3764

Backout: https://hg.mozilla.org/integration/autoland/rev/9704de323f3f60e596f262e5980f7828c72d9668

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/971bac1eeeab
Promisify state change events test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/525df90fb531
Fire state change event on LINKED change. r=Jamie,morgan
https://hg.mozilla.org/integration/autoland/rev/623db5d31305
Rename mac link test. r=morgan
https://hg.mozilla.org/integration/autoland/rev/7f2fc9ae7d7b
Expose unlinked a tags as AXGroup. r=morgan

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/971bac1eeeab
https://hg.mozilla.org/mozilla-central/rev/525df90fb531
https://hg.mozilla.org/mozilla-central/rev/623db5d31305
https://hg.mozilla.org/mozilla-central/rev/7f2fc9ae7d7b

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using old Nightly 2020-03-30, verified that this is fixed in latest Firefox Beta 77.0b4 on macOS 10.15.5 Beta.