1625962 - The Website address wrongly exceeds the Vulnerable Password notification area if it’s very long

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: LongAddress.PNG

[Affected versions]:

• Nightly 76.0a1 (Build ID: 20200329214909)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14.6
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a profile with at least 2 saved logins in which one is breached.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites
2. Create a vulnerable login with a long website address.
3. Observe the “Go to <webite_name>” link.

[Expected result]:

• The website address link from the “Vulnerable Password” is correctly displayed.

[Actual result]:

• The website address related to the vulnerable login exceeds the notification area.

[Notes]:

• Attached a screenshot of the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

The URL here is very abnormal and I would prefer that we not truncate the URL the user is about to click on since it is helpful

Comment 2

[Lesley Norton [:lnorton]]

Attachment: Bug 1625962 - Long website addresses inside of vulnerable password alert messages do not wrap. r=jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b613af5da5a
Long website addresses inside of vulnerable password alert messages do not wrap. r=jaws

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0b613af5da5a

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 77.0a1 (Build ID: 20200412214115) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The Website address does not exceed the Vulnerable Password notification area if it’s very long.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:lnorton, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9139652 [details]
Bug 1625962 - Long website addresses inside of vulnerable password alert messages do not wrap. r=jaws

Beta/Release Uplift Approval Request

• User impact if declined: Long website addresses may display outside of the vulnerable password notification box.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS-only change
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9139652 [details]
Bug 1625962 - Long website addresses inside of vulnerable password alert messages do not wrap. r=jaws

Simple CSS fix to avoid overflowing in some cases. Approved for 76.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a68b30e5ac84

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the Firefox Beta 76.0b5 (Build ID: 20200415234430) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The Website address does not exceed the Vulnerable Password notification area if it’s very long.