Remove unnecessary unload event listener when using privileged about content process
Categories
(Firefox :: New Tab Page, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
There's an unload event listener here: https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/browser/components/newtab/AboutNewTabService.jsm#225
this prevents about:home / about:newtab from entering the bfcache. Thankfully, this only occurs when the privileged about content process is enabled. It was added in bug 1416066 to, I think, address a potential leak.
Doing some probing and testing though (mainly be just removing the event listener), I'm not detecting any window leaks when I push to automation with that event listener removed. We should just get rid of it.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Here's the try push where I removed the event listener, showing no leaks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e581bbb07bef274ce38ad98809e61b28d676894e
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b509941a4f5 Remove unnecessary unload event listener from AboutNewTabChildService. r=k88hudson
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•