1626002 - Assertion failure: !mContent || !mContent->GetParentElement() || HTMLEditor::NodeIsBlockStatic(*mContent) || HTMLEditor::NodeIsBlockStatic(*mContent->GetParentElement()) || !mContent->GetParentElement()->IsEditable(), at /builds/worker/workspace/build/src

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P5)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Testcase found while fuzzing mozilla-central rev bf8af9af8047 (built with --enable-debug).

Assertion failure: !mContent || !mContent->GetParentElement() || HTMLEditor::NodeIsBlockStatic(*mContent) || HTMLEditor::NodeIsBlockStatic(*mContent->GetParentElement()) || !mContent->GetParentElement()->IsEditable(), at /builds/worker/workspace/build/src

rax = 0x000055580767d380   rdx = 0x0000000000000000
rcx = 0x0000000000000b40   rbx = 0x00007ffcaf172330
rsi = 0x00007f77a8dedb3b   rdi = 0x00007f77b481a680
rbp = 0x00007ffcaf172140   rsp = 0x00007ffcaf172120
r8 = 0x00007f77b481b8b0    r9 = 0x00007f77b599d780
r10 = 0x0000000000000000   r11 = 0x0000000000000000
r12 = 0x00007f77999b0ee0   r13 = 0x00000000af170080
r14 = 0x0000000000000000   r15 = 0x00007ffcaf172348
rip = 0x00007f77a5134133
OS|Linux|0.0.0 Linux 4.19.34-coreos #1 SMP Mon Apr 22 20:32:34 -00 2019 x86_64
CPU|amd64|family 6 model 62 stepping 4|16
GPU|||
Crash|SIGSEGV|0x0|0
0|0|libxul.so|mozilla::WSScanResult::AssertIfInvalidData() const|hg:hg.mozilla.org/mozilla-central:editor/libeditor/WSRunObject.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|167|0x49
0|1|libxul.so|mozilla::WSScanResult::WSScanResult(mozilla::EditorDOMPointBase<nsCOMPtr<nsINode>, nsCOMPtr<nsIContent> > const&, mozilla::WSType)|hg:hg.mozilla.org/mozilla-central:editor/libeditor/WSRunObject.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|159|0x8
0|2|libxul.so|mozilla::WSScanResult mozilla::WSRunScanner::ScanNextVisibleNodeOrBlockBoundaryFrom<nsINode*, nsIContent*>(mozilla::EditorDOMPointBase<nsINode*, nsIContent*> const&) const|hg:hg.mozilla.org/mozilla-central:editor/libeditor/WSRunObject.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|592|0x1c
0|3|libxul.so|mozilla::WSScanResult mozilla::WSRunScanner::ScanNextVisibleNodeOrBlockBoundary<nsINode*, nsIContent*>(mozilla::HTMLEditor const&, mozilla::EditorDOMPointBase<nsINode*, nsIContent*> const&)|hg:hg.mozilla.org/mozilla-central:editor/libeditor/WSRunObject.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|383|0x13
0|4|libxul.so|mozilla::HTMLEditor::MaybeCollapseSelectionAtFirstEditableNode(bool)|hg:hg.mozilla.org/mozilla-central:editor/libeditor/HTMLEditor.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|546|0x16
0|5|libxul.so|mozilla::HTMLEditor::NotifyRootChanged()|hg:hg.mozilla.org/mozilla-central:editor/libeditor/HTMLEditor.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|4815|0xa
0|6|libxul.so|mozilla::detail::RunnableMethodImpl<mozilla::HTMLEditor*, void (mozilla::HTMLEditor::*)(), true, (mozilla::RunnableKind)0>::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|1210|0xf
0|7|libxul.so|nsContentUtils::RemoveScriptBlocker()|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|5374|0x9
0|8|libxul.so|mozilla::dom::Document::EndUpdate()|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|7109|0x5
0|9|libxul.so|mozAutoDocUpdate::~mozAutoDocUpdate()|hg:hg.mozilla.org/mozilla-central:dom/base/mozAutoDocUpdate.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|34|0xd
0|10|libxul.so|nsINode::ReplaceOrInsertBefore(bool, nsINode*, nsINode*, mozilla::ErrorResult&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|2337|0xc
0|11|libxul.so|nsRange::CutContents(mozilla::dom::DocumentFragment**)|hg:hg.mozilla.org/mozilla-central:dom/base/nsRange.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1854|0x25
0|12|libxul.so|nsRange::ExtractContents(mozilla::ErrorResult&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsRange.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1896|0x5
0|13|libxul.so|mozilla::dom::Range_Binding::extractContents|s3:gecko-generated-sources:249c6028c0d832da8dcdabac72af437f25f49b556222d9127c7be2f6fcb792860b5261c857635930b087c1da798ce2bc37a8c4bb168872888a071cc793e08289/dom/bindings/RangeBinding.cpp:|810|0x23
0|14|libxul.so|bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|3171|0x21
0|15|libxul.so|CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), js::CallReason, JS::CallArgs const&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|477|0x19
0|16|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|569|0x12
0|17|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|632|0x10
0|18|libxul.so|Interpret|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|3046|0x16
0|19|libxul.so|js::RunScript(JSContext*, js::RunState&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|410|0x152
0|20|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|604|0xf
0|21|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|632|0x10
0|22|libxul.so|js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|649|0x8
0|23|libxul.so|JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/jsapi.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|2797|0x1f
0|24|libxul.so|mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&)|s3:gecko-generated-sources:9ca8646d8042e9b4b76d2e1b358b984be17743b71b832c0897d61bb500e0fecbe38fa54273dc522878c87fcb2c9bfd274a8190c7bc56fbbb58cb3ca68462e527/dom/bindings/EventListenerBinding.cpp:|52|0x5
0|25|libxul.so|mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*)|s3:gecko-generated-sources:f3d9c01258576daaac3afc4fb3b283652e7f1168abb5287eff6775451ebd0ab6a0e4c8d88d3a67f7147042501bc091c6dfed25b4b8ccf4e4f420897b8d0ba906/dist/include/mozilla/dom/EventListenerBinding.h:|66|0x1c
0|26|libxul.so|mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool)|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1271|0x1c
0|27|libxul.so|mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|326|0x6b
0|28|libxul.so|mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|558|0x12
0|29|libxul.so|mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*)|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1055|0x1a
0|30|libxul.so|nsDocumentViewer::LoadComplete(nsresult)|hg:hg.mozilla.org/mozilla-central:layout/base/nsDocumentViewer.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1144|0x1a
0|31|libxul.so|nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult)|hg:hg.mozilla.org/mozilla-central:docshell/base/nsDocShell.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|6084|0x18
0|32|libxul.so|nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult)|hg:hg.mozilla.org/mozilla-central:docshell/base/nsDocShell.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|5867|0x1c
0|33|libxul.so|nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult)|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1348|0x31
0|34|libxul.so|nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult)|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|907|0x2a
0|35|libxul.so|nsDocLoader::DocLoaderIsEmpty(bool)|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|727|0x15
0|36|libxul.so|nsDocLoader::OnStopRequest(nsIRequest*, nsresult)|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|615|0x16
0|37|libxul.so|mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult)|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsLoadGroup.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|604|0x1a
0|38|libxul.so|mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult)|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsLoadGroup.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|511|0xe
0|39|libxul.so|mozilla::dom::Document::DoUnblockOnload()|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|10675|0x4c
0|40|libxul.so|mozilla::dom::Document::UnblockOnload(bool)|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|10609|0x2a
0|41|libxul.so|mozilla::dom::Document::DispatchContentLoadedEvents()|hg:hg.mozilla.org/mozilla-central:dom/base/Document.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|7302|0xd
0|42|libxul.so|mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:bf8af9af80475880154922cf2465dc0b0ecd27fd|1210|0x5
0|43|libxul.so|mozilla::SchedulerGroup::Runnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|282|0x14
0|44|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|1220|0xe
0|45|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|481|0x11
0|46|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|87|0xa
0|47|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:bf8af9af80475880154922cf2465dc0b0ecd27fd|315|0x19
0|48|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:bf8af9af80475880154922cf2465dc0b0ecd27fd|290|0x8
0|49|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|137|0xd
0|50|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|926|0x6
0|51|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|237|0x5
0|52|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:bf8af9af80475880154922cf2465dc0b0ecd27fd|315|0x19
0|53|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:bf8af9af80475880154922cf2465dc0b0ecd27fd|290|0x8
0|54|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|761|0x8
0|55|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|56|0x14
0|56|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|303|0x13
0|57|libc-2.27.so||||0x21b97
0|58|firefox-bin|__cxa_throw_bad_array_new_length|hg:hg.mozilla.org/mozilla-central:build/unix/stdc++compat/stdc++compat.cpp:bf8af9af80475880154922cf2465dc0b0ecd27fd|82|0x12
0|59|firefox-bin||||0x10b20
0|60|libdl-2.27.so||||0x202d80
0|61|libpthread-2.27.so||||0x219bb0
0|62|firefox-bin||||0x10b20
0|63|firefox-bin|_start|||0x29

Comment 1

[Jason Kratzer [:jkratzer]]

Bugmon Analysis:
Verified bug as reproducible on mozilla-central 20200330155408-670a20bfd18a.
Failed to bisect testcase (Start build crashes!):
> Start: bf8af9af80475880154922cf2465dc0b0ecd27fd (20200303214128)
> End: 670a20bfd18a2ced1db8fc9a3234ef218c202b26 (20200330155408)
> BuildFlags: BuildFlags(asan=False, tsan=False, debug=True, fuzzing=False, coverage=False, valgrind=False)

Comment 2

[Jason Kratzer [:jkratzer]]

Bugmon Analysis:

Comment 3

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
The bug appears to have been fixed in the following build range:

Start: 8803bc71047a75f0983844d891d82b4a5edecda4 (20210310041823)
End: 194e31587e6c4174702a223b448e8748b1b4a144 (20210310045802)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8803bc71047a75f0983844d891d82b4a5edecda4&tochange=194e31587e6c4174702a223b448e8748b1b4a144
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 4

[Jason Kratzer [:jkratzer]]

:masayuki, is it possible this was fixed in bug 1677566?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Jason Kratzer [:jkratzer] from comment #4)

:masayuki, is it possible this was fixed in bug 1677566?

Yeah, probably, but we should add the testcase into the tree.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1626002 - Add reported testcase into the tree r=m_kato!

Depends on D122546

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00da70754201
Add reported testcase into the tree r=m_kato

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/00da70754201

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:masayuki, since this bug contains a bisection range, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 10

[Marco Castelluccio [:marco]]

Sorry, bug in the bot.