1626008 - Ensure the HitTestingTreeNode doesn't end up with stale sticky-pos data

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Spinoff from https://phabricator.services.mozilla.com/D64494#inline-406156 - while reviewing that patch I noticed that there might be a bug in the code with respect to populating the sticky-pos fields in HitTestingTreeNode. In particular, nodes may be recycled and the caller is responsible for repopulating data fields. This comment was written when hit-testing data was the only data stored in HTTN, but that comment should be updated to cover all the data fields. And the sticky pos data should be updated on the HTTN in all branches or unconditionally here and here.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=263e21b768163e34e91ff8de06a4f83fce42afb4

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1626008 - Ensure the HTTN data gets updated after recycling. r?botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1501bdf1379f
Ensure the HTTN data gets updated after recycling. r=botond

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1501bdf1379f