1626032 - [traceback] AttributeError: "MockedTelemetryBotoS3CrashStorage" object has no attribute "conn" in socorro/schemas/validate_and_test.py

Status: RESOLVED FIXED

(Socorro :: General, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We have a validate_and_test.py script that pulls down crash data and validates that the schema is correct and works with the crash data.

It looks like we haven't run this in a while and it's broken:

Traceback (most recent call last):
  File "socorro/schemas/validate_and_test.py", line 146, in <module>
    sys.exit(main())
  File "socorro/schemas/validate_and_test.py", line 140, in main
    run(args.crashes_per_url, *args.urls)
  File "socorro/schemas/validate_and_test.py", line 108, in run
    processor.save_processed_crash(raw_crash, processed_crash)
  File "socorro/schemas/validate_and_test.py", line 29, in save_processed_crash
    self.combined = super().save_processed_crash(raw_crash, processed_crash)
  File "/app/socorro/external/boto/crashstorage.py", line 335, in save_processed_crash
    self.conn.save_file(path, data)
AttributeError: 'MockedTelemetryBotoS3CrashStorage' object has no attribute 'conn'
app@socorro:/app$ 

This bug covers fixing it.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to fix now. It blocks me from adding new fields to the schema.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5325: bug 1626032: fix validate_and_test script

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5325: "bug 1626032: fix validate_and_test script" in dd8615f.

I need to write up a new bug for writing a basic test for this. I wrote that up in bug #1626632.

This only affects local dev environment stuff. Marking as FIXED.