1626105 - Make all the UTF-8 compilation/evaluation functions not inflate to UTF-16

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jeff Walden [:Waldo]]

When we implemented UTF-8 tokenizing (and then compilation and evaluation), we hid them behind fresh new *DontInflate symbols so that it would be easy to transition individual uses over to non-inflating -- just in case the non-inflating forms contained any bugs. Now that the non-inflating behavior is used pretty much everywhere in the browser (and internally in the browser), it should be as safe as it reasonably can be to make not-inflating the default behavior.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::Compile| for UTF-8 to |JS::CompileDontInflate| semantics, and remove |JS::CompileDontInflate|. r=evilpie!

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::CompileUtf8Path| to |JS::CompileUtf8PathDontInflate| semantics, and remove |JS::CompileUtf8PathDontInflate|. r=evilpie!

Depends on D68905

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::CompileUtf8File| to |JS::CompileUtf8FileDontInflate| semantics, and remove |JS::CompileUtf8FileDontInflate|. r=evilpie!

Depends on D68906

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::CompileForNonSyntacticScope| to |JS::CompileForNonSyntacticScopeDontInflate| semantics, and remove |JS::CompileForNonSyntacticScopeDontInflate|. r=evilpie!

Depends on D68907

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::EvaluateUtf8Path| to |JS::EvaluateUtf8PathDontInflate| semantics, and remove |JS::EvaluateUtf8PathDontInflate|. r=evilpie!

Depends on D68908

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Convert |JS::Evaluate| to |JS::EvaluateDontInflate| semantics, and remove |JS::EvaluateDontInflate|. r=evilpie!

Depends on D68910

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Bug 1626105 - Rename |JS::CompileModuleDontInflate| to just plain |JS::CompileModule|. (There is no non-inflating version remove at the same time.) r=evilpie!

Depends on D68911

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b387c53da3f
Convert |JS::Compile| for UTF-8 to |JS::CompileDontInflate| semantics, and remove |JS::CompileDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/740c30b808cf
Convert |JS::CompileUtf8Path| to |JS::CompileUtf8PathDontInflate| semantics, and remove |JS::CompileUtf8PathDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/41a9bd6821d9
Convert |JS::CompileUtf8File| to |JS::CompileUtf8FileDontInflate| semantics, and remove |JS::CompileUtf8FileDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/3cdf1ead6e13
Convert |JS::CompileForNonSyntacticScope| to |JS::CompileForNonSyntacticScopeDontInflate| semantics, and remove |JS::CompileForNonSyntacticScopeDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/83c0ace14804
Convert |JS::EvaluateUtf8Path| to |JS::EvaluateUtf8PathDontInflate| semantics, and remove |JS::EvaluateUtf8PathDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/e8d6c70a21a4
Convert |JS::Evaluate| to |JS::EvaluateDontInflate| semantics, and remove |JS::EvaluateDontInflate|.  r=evilpie
https://hg.mozilla.org/integration/autoland/rev/dbd536bcafed
Rename |JS::CompileModuleDontInflate| to just plain |JS::CompileModule|.  (There is no non-inflating version remove at the same time.)  r=evilpie

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6b387c53da3f
https://hg.mozilla.org/mozilla-central/rev/740c30b808cf
https://hg.mozilla.org/mozilla-central/rev/41a9bd6821d9
https://hg.mozilla.org/mozilla-central/rev/3cdf1ead6e13
https://hg.mozilla.org/mozilla-central/rev/83c0ace14804
https://hg.mozilla.org/mozilla-central/rev/e8d6c70a21a4
https://hg.mozilla.org/mozilla-central/rev/dbd536bcafed