Closed Bug 1626128 Opened 4 years ago Closed 4 years ago

Move `BridgedEngine` from `golden_gate_traits` into `sync15_traits`

Categories

(Firefox :: Sync, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox77 --- fixed

People

(Reporter: lina, Assigned: lina)

References

()

Details

(Whiteboard: SACI)

Attachments

(1 file)

Bug 1596322 added a separate golden_gate_traits crate with the BridgedEngine trait, to make it easier to split out eventually. Once we've vendored sync15_traits (bug 1626125), let's move BridgedEngine into it.

This work will happen in both m-c and a-s. On the a-s side, we'll open a PR to land the trait in sync15_traits. On the m-c side, we'll remove the golden_gate_traits crate, and change golden_gate to depend on sync15_traits instead.

Whiteboard: SACI
Blocks: 1623245
No longer blocks: 1623245

Now that BridgedEngine has been moved to sync15_traits, we can
remove golden_gate_traits from the tree, and change Golden Gate to
depend on sync15_traits directly.

This commit also adds a Cargo feature, services_sync, which reflects
the MOZ_SERVICES_SYNC config option. In the future, we'll use this
feature to gate implementations of mozIBridgedSyncEngine.

Assignee: nobody → lina
Status: NEW → ASSIGNED
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f028f48db930
Change Golden Gate to depend on `sync15_traits`. r=markh
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: