1626180 - Local Alias is not working in IRC

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 2

[Patrick Cloke [:clokep]]

Khushil -- any idea how hard this is to fix? I'm guessing this is not specific to IRC and all local aliases for chat is broken.

Comment 3

[Khushil Mistry [:khushil324]]

It was working for XMPP when I filed this bug. For the IRC, it's a few minor changes I guess. We are not setting up the right nickname in GenericAccountPrototype.

Comment 4

[Khushil Mistry [:khushil324]]

This is a small change so taking this up.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1626180_local-alias-IRC-0.patch

Comment 6

[Patrick Cloke [:clokep]]

Khushil -- I'm quite surprised by the changes in this patch, can you describe the what exactly isn't working with IRC and how this fixes it?

Comment 7

[Khushil Mistry [:khushil324]]

(In reply to Patrick Cloke [:clokep] from comment #6)

Khushil -- I'm quite surprised by the changes in this patch, can you describe the what exactly isn't working with IRC and how this fixes it?

I am following this: https://searchfox.org/comm-central/source/chat/protocols/xmpp/xmpp-base.jsm#156
We were not considering alias anywhere in the IRC. So when we write outgoing message, we try to get alias if user has set that same as XMPP.

Comment 8

[Patrick Cloke [:clokep]]

There's I think 3 or 4 different things we use the term "alias" for in the chat code, can you be more specific about which alias you're talking about? Is it another user's local alias (this is what I thought this bug was about...), or local alias, a server alias, something else?

Can you give steps to test this?

Comment 9

[Khushil Mistry [:khushil324]]

It's related to our local alias, at least I am thinking that. I am not aware of any other alias usage.

Previously if I set my local alias to "Khushil" and my server username is "khushil324" it was showing:

khushil324: Hello
clokep: How are you?

Now:

Khushil: Hello
clokep: How are you?

Comment 10

[Khushil Mistry [:khushil324]]

Do you have any other usage in mind?

Comment 11

[Patrick Cloke [:clokep]]

Comment on attachment 9151159 [details] [diff] [review]
Bug-1626180_local-alias-IRC-0.patch

Review of attachment 9151159 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/irc.jsm
@@ +324,5 @@
>      // assume the message was received and immediately show it.
>      if (!this._account._activeCAPs.has("echo-message")) {
> +      this.writeMessage(
> +        this._account.imAccount.alias ||
> +          this._account.imAccount.statusInfo.displayName ||

I don't think this statusInfo object is something you can even set in Thunderbird, but good to be consistent. :(

Comment 12

[Khushil Mistry [:khushil324]]

(In reply to Patrick Cloke [:clokep] from comment #11)

I don't think this statusInfo object is something you can even set in
Thunderbird, but good to be consistent. :(

If I update the username in the Show Accounts dialog box, statusInfo object is also getting updated.
So if I don't set an alias and my display name from the Show Account Dialog box is "Khushil-324".

Khushil-324: Hey
clokep: Hey
// Update the display name to "Khushil"
Khushil: Hello Again!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a18b970b5be8
Fix Local Alias is not working in IRC. r=clokep