Closed Bug 1626188 Opened 4 years ago Closed 4 years ago

load_shader.h is not generated deterministically

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: glandium, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [stockwell unknown][tor 34015])

Attachments

(1 file)

This should have shown up whenever changes to the build script generated these changes, but didn't because of bug 1626163. It only recently surfaced as a generated code difference because the variance in load_shader.h now induces some difference in the order some functions appear in the binary.
See https://firefoxci.taskcluster-artifacts.net/ObjR4GipRpCsvtRm_VED2w/0/public/diff.html

(incidentally, it also means possible cache misses when building with ccache or sccache)

Priority: -- → P3

Jessie can you assign someone to take a look at this? There are15 failures in the last 7 days, all on diff opt.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295739518&repo=mozilla-central&lineNumber=6812

[task 2020-04-01T12:00:54.469Z] |########################## | 97% xpcom/ds/nsGkAtomConsts.h ETA: 0:00:00
[task 2020-04-01T12:00:54.472Z] |########################## | 97% xpcom/ds/nsGkAtomList.h ETA: 0:00:00
[task 2020-04-01T12:00:54.473Z] |########################## | 98% …parser/xpidl/xpidllex.py ETA: 0:00:00
[task 2020-04-01T12:00:54.474Z] |########################## | 98% …arser/xpidl/xpidlyacc.py ETA: 0:00:00
[task 2020-04-01T12:00:54.479Z] |########################## | 98% …lect/xptinfo/xptdata.cpp ETA: 0:00:00
[task 2020-04-01T12:00:54.480Z] |########################## | 99% …s/gtest/dafsa_test_1.inc ETA: 0:00:00
[task 2020-04-01T12:00:54.481Z] |########################## | 99% xpcom/xpcom-config.h ETA: 0:00:00
[task 2020-04-01T12:00:54.482Z] |########################## | 99% xpcom/xpcom-private.h ETA: 0:00:00
[task 2020-04-01T12:00:54.484Z] |###########################| 100% ETA: 0:00:00
[task 2020-04-01T12:00:54.484Z] |###########################| 100% ETA: 0:00:00
[task 2020-04-01T12:00:54.484Z] |###########################| 100% ETA: 0:00:00
[task 2020-04-01T12:00:54.484Z] |###########################| 100% ETA: 0:00:00
[task 2020-04-01T12:00:54.825Z] |###########################| 100% Time: 0:00:09
[task 2020-04-01T12:00:54.825Z] + report_error diff
[task 2020-04-01T12:00:54.825Z] + python3
[task 2020-04-01T12:00:54.835Z] TEST-UNEXPECTED-FAIL | target.generated-files.tar.gz/target.generated-files.tar/i686-unknown-linux-gnu/release/build/swgl-77a71763a275eb7b/out/load_shader.h differs. See the diff.html or diff.txt artifact
[task 2020-04-01T12:00:54.836Z] + fail
[task 2020-04-01T12:00:54.836Z] + exit 1
[taskcluster 2020-04-01 12:00:55.456Z] === Task Finished ===
[taskcluster 2020-04-01 12:00:56.147Z] Unsuccessful task run with exit code: 1 completed in 33.47 seconds

Please note there is a conversation on this here also: https://bugzilla.mozilla.org/show_bug.cgi?id=1596350

Flags: needinfo?(jbonisteel)
Whiteboard: [stockwell needswork:owner]
Flags: needinfo?(lsalzman)
Flags: needinfo?(lsalzman)
Flags: needinfo?(jbonisteel)
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faa791f721b8
ensure shader keys are in sorted order. r=jimb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Please file a new one. Same component (webrender). Please Cc me.

Flags: needinfo?(mh+mozilla)

And please mark that new bug as regressed by bug 1604615, which is the likely cause.

Whiteboard: [stockwell unknown] → [stockwell unknown][tor 34015]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: