Closed Bug 1626233 Opened 5 years ago Closed 5 years ago

Fix multi-value calls in Ion

Categories

(Core :: JavaScript: WebAssembly, defect)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Bug 1626233 - Fix multi-value calls with Ion
47 bytes, text/x-phabricator-request
Details | Review

There are a couple bugs in WasmIonCompile for multi-value calls:

  • Stack result areas were not being correctly aligned
  • GVN would consider MWasmDerivedPointer instances to be equivalent if they had the same base pointer but different offsets

This patch will fix these bugs.

This patch fixes a couple bugs in WasmIonCompile for multi-value calls:

  • Stack result areas were not being correctly aligned

  • GVN would consider MWasmDerivedPointer instances to be equivalent if
    they had the same base pointer but different offsets

Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb9965b85d43 Fix multi-value calls with Ion r=lth

https://hg.mozilla.org/mozilla-central/rev/cb9965b85d43

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: