1626260 - Investigate if we can get the hasStoragePermission for the unopened channel in ReferrerInfo::GetDefaultReferrerPolicy()

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Tim Huang[:timhuang]]

We will need the hasStoragePermission flag to do ContentBlocking checks for channels in ETP Fission. This flag would first be calculated in the parent process when opening the channel. However, there are cases that we do the check before the channel has been opened.

One case here is when we get the default ReferrerPolicy for a channel here.

This bug is for investigating that if we have a way to address this.

Comment 1

[Tim Huang[:timhuang]]

In the case that we get the default referrer policy before the channel is opened, we should not do the content blocking check here if it's in the child process. It's because the channel here hasn't been classified yet, the channel we use here would never be considered as a tracker. So, this check is unnecessary. And the referrer policy would be updated in the parent when we know the tracking state before connecting.

Give this, I think we should stop doing content blocking check in child processes when getting the default referrer policy.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1626260 - Stop doing content blocking checks when getting the default referrer policy in content processes. r?dimi,baku!,ckerschb!

Right now, we do a content blocking check when we get the default
referrer policy. And this could happen even before the channel is
opened. This is undesirable for the ETP fission work since we need
information that is calculated when the channel is opened in the parent
to do a content blocking check.

And we find out that doing a content blocking check here is unnecessary
since the tracking state here is not decided yet since the channel
hasn't been opened. And we will update the referrer policy in the parent
once the tracking state is ready.

So, in this patch, we stop doing the content blocking checks when
getting the default referrer policy in content processes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26759b0dc1fa
Stop doing content blocking checks when getting the default referrer policy in content processes. r=dimi,baku,ckerschb

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/26759b0dc1fa