Closed Bug 1626276 Opened 5 years ago Closed 5 years ago

Elements with visibility: hidden shouldn't show ellipsis

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

()

Details

Attachments

(2 files)

Testcase: data:text/html,<div style="visibility: hidden; display: -webkit-box; -webkit-box-orient: vertical; -webkit-line-clamp: 3; width: 50px; overflow: hidden;">aaaaaaa<br><br>aaaa<br>aaaa<br>aa</div>

AR: Shows ellipsis
ER: should not show ellipsis

Assignee: nobody → ntim.bugs

Here's the same issue for text-overflow: ellipsis:

data:text/html,<div style="visibility: hidden; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; width: 40px"><span style="visibility: visible">aaaaaaaaaaaaaaaaaaaaaaaaaaaa</span></div>
Attachment #9137163 - Attachment description: Bug 1626276 - Don't render -webkit-line-clamp ellipsis on visibility: hidden; elements. → Bug 1626276 - Don't render ellipsis on visibility: hidden; elements.
Summary: Elements with -webkit-line-clamp and visibility: hidden shouldn't show ellipsis → Elements with visibility: hidden shouldn't show ellipsis
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/70ec5e9cd716 Don't render ellipsis on visibility: hidden; elements. r=emilio
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b4b9a6a7f537 Followup: Import Ahem font in webkit-line-clamp-035.html.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22578 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Upstream PR merged by moz-wptsync-bot

Hmm...is the test really correct? The spec say:

The ellipsis is styled and baseline-aligned according to the block.
https://drafts.csswg.org/css-ui-3/#ellipsing-details

so the ellipsis should be hidden, no?

^ Ah, sorry, nvm, misunderstood "shouldn't show" as "should show".

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: