Closed Bug 1626386 Opened 6 months ago Closed 4 months ago

Convert ui.menu.incremental_search.timeout to a static pref and expand its uses

Categories

(Core :: Preferences: Backend, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The varcache pref ui.menu.incremental_search.timeout not only needs to be converted to a static pref, but it is noted above the mirror variable that it should actually be kept in sync with macros in other parts of the code (there are no checks to ensure these are in sync) [1]. In order to ensure these are all kept in sync, I think we need to expand the use of this pref to other incremental search timeout constants that should reflect the same value.

[1] https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/layout/xul/nsMenuPopupFrame.cpp#76-79

Converts ui.menu.incremental_search.timeout to a static pref and replaces macros related to the incremental search timeout with the actual pref, so that they are kept in sync without the need to manually update any macros. The two .xml files mentioned in the note were nowhere to be found, so this patch makes the assumption that those do not exist anymore and do not need to be kept in sync.

Assignee: nobody → kwright
Status: NEW → ASSIGNED
Blocks: 1639343
Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a03ca1bbfefa
Convert ui.menu.incremental_search.timeout to a static pref r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.