1626419 - Full Screen menu item doesn't work when the fullscreen API is blocked via HTTP Feature-Policy

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tim Nguyen :ntim]

STR:

• Open a web page with a feature policy that blocks fullscreen which has a video on it
• Right click the video
• Click the "Full screen" menu item

AR:

• the menu item is enabled, but clicking it doesn't work

Console warning: Request for fullscreen was denied because of FeaturePolicy directives.

ER:
The menu item should either be hidden/disabled, or it should properly work.

Comment 1

[Anne (:annevk)]

We shouldn't support the HTTP header. Did that end up shipping somehow?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Anne (:annevk) from comment #1)

We shouldn't support the HTTP header. Did that end up shipping somehow?

302 to Johann who is in a better position to answer.

Comment 3

[Johann Hofmann [:johannh]]

It's enabled in Nightly, apparently. We could consider turning it off in Nightly as well, but that's probably not the point of this bug, since I expect the same thing to happen with allow attributes?

Comment 4

[Tim Nguyen :ntim]

Thanks Jared for the testcase!

For the HTTP feature policy case (and allow attributes), I think can add && aCallerType != CallerType::System at https://searchfox.org/mozilla-central/rev/4ccefc3181f9d237ef4ca8bd17b4e7c101ddf7b5/dom/base/Element.cpp#3140

For the "legacy" allowfullscreen attribute, AFAIK we already allow it: https://searchfox.org/mozilla-central/rev/4ccefc3181f9d237ef4ca8bd17b4e7c101ddf7b5/dom/base/Document.cpp#13513-13529

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1626419 - Move FeaturePolicy check to GetFullscreenError after CallerType check.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9f5c8ec753
Move FeaturePolicy check to GetFullscreenError after CallerType check. r=emilio

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4c9f5c8ec753

Comment 9

[Anne (:annevk)]

I filed bug 1627890 on disabling/removing the header code.