1626526 - TypeError: can't access property "spec", topFrame.currentURI is null: _onRequest@chrome://remote/content/domains/parent/Network.jsm:383:20

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This fails a lot in Puppeteer unit tests, and I wonder how many test failures it actually produces. Here the exact failure:

[task 2020-04-01T05:21:34.524Z] PID 91 |   TypeError: can't access property "spec", topFrame.currentURI is null: _onRequest@chrome://remote/content/domains/parent/Network.jsm:383:20
[task 2020-04-01T05:21:34.524Z] PID 91 | emit@resource://gre/modules/EventEmitter.jsm:160:20
[task 2020-04-01T05:21:34.525Z] PID 91 | _onRequest@chrome://remote/content/domains/parent/network/NetworkObserver.jsm:281:10

The appropriate source is here:

https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/remote/domains/parent/Network.jsm#383

As it looks like the object as returned by getLoadContext(httpChannel) doesn't have a topFrameElement property. Note that this method also has a duplicate in NetworkObserver.jsm.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is actually not causing test failures, but is all related to network requests not initiated by the target, but the browser itself. And for all the cases I have seen so far this is for the favicon.ico file.

So _onRequest in NetworkObserver.jsm has to return early if there is no valid URI for the topFrameElement. Also we should not send Network.requestWillBeSent events for these kind of network requests given that Chrome is also not doing that.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The latter proposal seems to be harder to manage and would need a bit of refactoring of the network event code. I would propose to just get rid of the failure for now so that we have cleaner Puppeteer logs.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bdbe80726f6263daf3b971069161b6866e01deb

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1626526 - [remote] Don't emit internal network request events for invalid top frame elements.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f554112cb7bd
[remote] Don't emit internal network request events for invalid top frame elements. r=remote-protocol-reviewers,maja_zf

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f554112cb7bd