Remove Loader.jsm exceptions from Android allowed-dupes.mn
Categories
(DevTools :: Shared Components, task)
Tracking
(firefox76 fixed)
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: ntim, Assigned: aarushivij, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
I've removed some similar ones in https://hg.mozilla.org/mozilla-central/rev/7ef399bfae0d#l2.13 (because those files have been deleted/moved since).
However, Loader.jsm still exists, so I'm wondering if those exceptions are still needed.
It's worth noting that only the mobile allowed-dupes.mn file has this exception.
Julian, do you know if we still need those ?
|
||
Comment 1•4 years ago
|
||
Thanks for the ping! We removed the entries in the other allowed-dupes.mn file in https://bugzilla.mozilla.org/show_bug.cgi?id=1566457 but we missed the Android one.
They should be removed as well.
|
Reporter | |
Comment 2•4 years ago
|
||
Thanks Julian!
To fix this bug, you'll need to remove:
modules/devtools/Loader.jsm
modules/devtools/shared/Loader.jsm
from mobile/android/installer/allowed-dupes.mn
|
Assignee | |
Comment 3•4 years ago
|
||
Hello, Can I take this bug?
Thanks :)
Aarushi
|
|
Assignee | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 4•4 years ago
|
||
Sure, please feel free to submit a patch. Let me know if you've got any questions.
|
|
Reporter | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5bea15a54065 Remove Loader.jsm exceptions from Android allowed-dupes.mn. r=ntim
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•