1626578 - [Tier2] SM gdb - Test assertion failed: expected: '$JS::Value("")' actual: '$JS::Value()'

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Narcis Beleuzu [:NarcisB]]

Started with : https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295721663&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=9ac72a05864283683d1aebd688f7e48a6b54142d
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295721663&repo=autoland&lineNumber=7162

Log snippet:
[task 2020-04-01T10:01:12.169Z] Standard error:
[task 2020-04-01T10:01:12.169Z] Traceback (most recent call last):
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/mozilla/JSString.py", line 89, in to_string
[task 2020-04-01T10:01:12.169Z] for c in self.chars():
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/mozilla/JSString.py", line 46, in chars
[task 2020-04-01T10:01:12.169Z] flags = self.value['flags_']
[task 2020-04-01T10:01:12.169Z] gdb.error: There is no member or method named flags_.
[task 2020-04-01T10:01:12.169Z]
[task 2020-04-01T10:01:12.169Z] Assertion traceback for jsval.simple:
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/lib-for-tests/prologue.py", line 105, in <module>
[task 2020-04-01T10:01:12.169Z] execfile(testscript, globals(), locals())
[task 2020-04-01T10:01:12.169Z] File "<string>", line 25, in execfile
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/tests/test-jsval.py", line 16, in <module>
[task 2020-04-01T10:01:12.169Z] assert_pretty('empty_string', '$JS::Value("")')
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/lib-for-tests/prologue.py", line 60, in assert_pretty
[task 2020-04-01T10:01:12.169Z] assert_eq(str(value), form)
[task 2020-04-01T10:01:12.169Z] File "/builds/worker/workspace/build/src/js/src/gdb/lib-for-tests/prologue.py", line 42, in assert_eq

Comment 1

[Cosmin Sabou [:CosminS]]

This was backed out in https://bugzilla.mozilla.org/show_bug.cgi?id=1625212#c26

Backout link: https://hg.mozilla.org/integration/autoland/rev/0a07f96b0b411e4867fa58a91738d542e1c3fce7

Green on the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=sm%2Cgdb&revision=3b4a2d668c0a4ab05ccd584701cd063d768dd0e3&selectedJob=295786436

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1626578 - Update gdb pretty printers in line with CellHeader changes r?sfink

Comment 3

[Intermittent Failures Robot]

9 failures in 5015 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9

Platform breakdown:

• linux64: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1626578&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 4

[Phabricator Automation]

Comment on attachment 9137979 [details]
Bug 1626578 - Update gdb pretty printers in line with CellHeader changes r?sfink

Revision D69513 was moved to bug 1625212. Setting attachment 9137979 [details] to obsolete.