1626600 - Do not allow Picture-in-Picture via the context menu on a video that has not loaded anything yet

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Paul Adenot (:padenot)]

Attachment: pip-src.html

STR:

1. Load the test case
2. Put the video in pip mode via the right click
3. Click the first button, this loads the media, you should see the element changing size
4. Click the second button

Expected:

1. The media plays in the PiP window

Actual:

1. The PiP window is small and the video isn't displayed there anyways

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hm. I suspect we probably shouldn't be allowing the user to Picture-in-Picture a non-video, like what the testcase starts with.

Is PiP'ing an empty video a prerequisite for reproducing this bug?

Comment 2

[Alastor Wu [:alwu]]

Per comment1, so maybe we should disable the option of PIP when the media element hasn't loaded any data yet.

Comment 3

[Paul Adenot (:padenot)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

Hm. I suspect we probably shouldn't be allowing the user to Picture-in-Picture a non-video, like what the testcase starts with.

Is PiP'ing an empty video a prerequisite for reproducing this bug?

This media file has a video track. The steps are all necessary to reproduce. The HTMLVideoElement has an empty src when activating PiP, yes.

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 5

[Oliver Pope]

Attachment: Bug 1626600 - added check for readyState in nsContextMenu to see if PiP should display r=mtigley,mhowell

Comment 6

[Oliver Pope]

Attachment: Bug 1626600 - removed PiP from browser_contextmenu tests r=mconley

Depends on D102864

Comment 7

[Oliver Pope]

Attachment: Bug 1626600 - added test for testing a real, working video r=mtigley,mhowell

Depends on D102865

Comment 8

[Oliver Pope]

Attachment: Bug 1626600 - removed test for checking PiP with real video bc that test already exists r=mtigley,mhowell

Depends on D102866

Comment 9

[Oliver Pope]

Attachment: Bug 1626600 - removed test for checking PiP with real video bc that test already exists r=mtigley,mhowell

Depends on D102867

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d8ed4244d23
added check for readyState in nsContextMenu to see if PiP should display r=mtigley,mhowell
https://hg.mozilla.org/integration/autoland/rev/375506876a81
removed PiP from browser_contextmenu tests r=mhowell

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3d8ed4244d23
https://hg.mozilla.org/mozilla-central/rev/375506876a81

Comment 12

[Ciprian Georgiu, Desktop QA]

I've reproduced this issue on an affected Nightly build from 2020-04-01, using the steps from comment 0.

Picture-in-Picture is not displayed anymore on the latest Beta 86.0b3, across OSs: Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.