1626699 - It should be easier to set/return !Maybe than `Nothing()`

Status: NEW

(Core :: MFBT, defect, P3)

Description

[Kelsey Gilbert [:jgilbert]]

Previously we could return {}; to indicate !Maybe.
Now we must generally return Nothing();, which is both more characters (visual load) and looks like a function call (cognitive load).

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1626699 - Add implicit `Maybe<nullopt_t>()`.

using std::nullopt as mozilla::nullopt, a la nullptr.
E.g. instead of maybe = Nothing(), just maybe = nullopt or maybe = {}.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jgilbert, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Just thought about this:

(In reply to Jeff Gilbert [:jgilbert] from comment #0)

return Nothing();, which ... looks like a function call (cognitive load).

Note that you could write return Nothing{}; (with curly braces) to avoid the function call look. 😉 But yes it's still 7 more characters than {} alone.

Comment 5

[Kelsey Gilbert [:jgilbert]]

I know, but thanks! That's not my priority here.