Closed Bug 1626727 Opened 5 years ago Closed 5 years ago

ReferenceError: isEvalSource is not defined

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: agi, Unassigned)

References

(Regression)

Details

(Keywords: regression)

What were you doing?

  1. Connect to a GeckoView-powered browser through about:debugging (e.g. GeckoViewExample)

What happened?

Devtools code throws this error:

04-01 12:35:47.510 25676 25708 E Web Content: [JavaScript Error: "ReferenceError: isEvalSource is not defined"]
04-01 12:35:47.511 25676 25708 I GeckoDump: DBG-SERVER threw an exception: ReferenceError: isEvalSource is not defined
04-01 12:35:47.511 25676 25708 I GeckoDump: Stack: createSourceActor@resource://devtools/server/actors/utils/TabSources.js:299:17
04-01 12:35:47.511 25676 25708 I GeckoDump: _addSource@resource://devtools/server/actors/thread.js:1924:34
04-01 12:35:47.511 25676 25708 I GeckoDump: onNewScript@resource://devtools/server/actors/thread.js:1879:10
04-01 12:35:47.511 25676 25708 I GeckoDump: load@resource://devtools/shared/base-loader.js:160:27
04-01 12:35:47.511 25676 25708 I GeckoDump: _require@resource://devtools/shared/base-loader.js:356:23
04-01 12:35:47.511 25676 25708 I GeckoDump: requireHook@resource://devtools/shared/Loader.jsm:107:14
04-01 12:35:47.511 25676 25708 I GeckoDump: require@resource://devtools/shared/base-loader.js:310:14
04-01 12:35:47.511 25676 25708 I GeckoDump: @resource://devtools/server/actors/source.js:14:28
04-01 12:35:47.511 25676 25708 I GeckoDump: load@resource://devtools/shared/base-loader.js:160:27
04-01 12:35:47.511 25676 25708 I GeckoDump: _require@resource://devtools/shared/base-loader.js:356:23
04-01 12:35:47.511 25676 25708 I GeckoDump: requireHook@resource://devtools/shared/Loader.jsm:107:14
04-01 12:35:47.511 25676 25708 I GeckoDump: require@resource://devtools/shared/base-loader.js:310:14
04-01 12:35:47.511 25676 25708 I GeckoDump: lazyRequireGetter/<@resource://devtools/shared/builtin-modules.js:180:9
04-01 12:35:47.511 25676 25708 I GeckoDump: get@resource://devtools/shared/builtin-modules.js:108:28
04-01 12:35:47.511 25676 25708 I GeckoDump: createSourceActor@resource://devtools/server/actors/utils/TabSources.js:299:17
04-01 12:35:47.511 25676 25708 I GeckoDump: _addSource@resource://devtools/server/actors/thread.js:1924:34
04-01 12:35:47.511 25676 25708 I GeckoDump: onNewScript@resource://devtools/server/actors/thread.js:1879:10
04-01 12:35:47.511 25676 25708 I GeckoDump: load@resource://devtools/shared/base-loader.js:160:27
04-01 12:35:47.511 25676 25708 I GeckoDump: _require@resource://devtools/shared/base-loader.js:356:23
04-01 12:35:47.511 25676 25708 I GeckoDump: requireHook@resource://devtools/shared/Loader.jsm:107:14
04-01 12:35:47.511 25676 25708 I GeckoDump: require@resource://devtools/shared/base-loader.js:310:14
04-01 12:35:47.511 25676 25708 I GeckoDump: lazyRequireGetter/<@resource://devtools/shared/builtin-modules.js:180:9
04-01 12:35:47.511 25676 25708 I GeckoDump: get@resource://devtools/shared/builtin-modules.js:108:28
04-01 12:35:47.511 25676 25708 I GeckoDump: onAttach@resource://devtools/server/actors/thread.js:376:5
04-01 12:35:47.511 25676 25708 I GeckoDump: onPacket@resource://devtools/server/devtools-server-connection.js:380:58
04-01 12:35:47.511 25676 25708 I GeckoDump: receiveMessage@resource://devtools/shared/transport/child-transport.js:66:16
04-01 12:35:47.511 25676 25708 I GeckoDump: Line: 299, column: 17

I'm on latest nightly (both desktop and emulator browser)

This trace implies that the debugger may be trying to debug itself somehow which is not great.

@ochameau, any thoughts?

@agi Are you able to do any bisecting of the Android build to give us a sense of when this was introduced?

Flags: needinfo?(poirot.alex)
Flags: needinfo?(agi)

Yes. I'll post a bisect result soon (keeping the ni so I remember)

This is most likely a recent regression and not specific to Android.
I see similar exception when opening the browser console.
I imagine it will be easier to understand what is wrong here when we identify the regression source.

$ MOZCONFIG=mozconfig-firefox-artifact ./mach run
 0:00.31 /mnt/desktop/gecko-dev/obj-firefox-artifact/dist/bin/firefox -no-remote -profile /mnt/desktop/gecko-dev/obj-firefox-artifact/tmp/profile-default
DevTools Server for Browser Toolbox listening on port: 37381
Starting Browser Toolbox /mnt/desktop/gecko-dev/obj-firefox-artifact/dist/bin/firefox-bin -no-remote -foreground -profile /mnt/desktop/gecko-dev/obj-firefox-artifact/tmp/profile-default/chrome_debugger_profile -chrome chrome://devtools/content/framework/browser-toolbox/window.html -purgecaches
JavaScript warning: resource://devtools/shared/builtin-modules.js, line 180: debuggee `resource://devtools/shared/base-loader.js:299' would run
DBG-SERVER threw an exception: ReferenceError: isEvalSource is not defined
Stack: createSourceActor@resource://devtools/server/actors/utils/TabSources.js:299:17
_addSource@resource://devtools/server/actors/thread.js:1924:34
onNewScript@resource://devtools/server/actors/thread.js:1879:10
load@resource://devtools/shared/base-loader.js:160:27
_require@resource://devtools/shared/base-loader.js:356:23
requireHook@resource://devtools/shared/Loader.jsm:107:14
require@resource://devtools/shared/base-loader.js:310:14
lazyRequireGetter/<@resource://devtools/shared/builtin-modules.js:180:9
get@resource://devtools/shared/builtin-modules.js:108:28
createSourceActor@resource://devtools/server/actors/utils/TabSources.js:299:17
_addSource@resource://devtools/server/actors/thread.js:1924:34
onNewScript@resource://devtools/server/actors/thread.js:1879:10
load@resource://devtools/shared/base-loader.js:160:27
_require@resource://devtools/shared/base-loader.js:356:23
requireHook@resource://devtools/shared/Loader.jsm:107:14
require@resource://devtools/shared/base-loader.js:310:14
lazyRequireGetter/<@resource://devtools/shared/builtin-modules.js:180:9
get@resource://devtools/shared/builtin-modules.js:108:28
onAttach@resource://devtools/server/actors/thread.js:376:5
onPacket@resource://devtools/server/devtools-server-connection.js:380:58
_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
Line: 299, column: 17
console.error: (new ReferenceError("isEvalSource is not defined", "resource://devtools/server/actors/utils/TabSources.js", 299))
Flags: needinfo?(poirot.alex)
Summary: ReferenceError: isEvalSource is not defined when connecting to GeckoView Example → ReferenceError: isEvalSource is not defined
10:33.65 INFO: Last good revision: 0e780f94d2b2fed8fef9f76177891b2f9063d08a
10:33.65 INFO: First bad revision: eb632d0b3a7b80faece5fda635e7b770ed1da44a
10:33.65 INFO: Pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e780f94d2b2fed8fef9f76177891b2f9063d08a&tochange=eb632d0b3a7b80faece5fda635e7b770ed1da44a

Flags: needinfo?(agi)

Verified that reverting https://hg.mozilla.org/integration/autoland/rev/eb632d0b3a7b80faece5fda635e7b770ed1da44a locally fixes the problem for me.

Regressed by: 1622718
Has Regression Range: --- → yes

Sorry about that. https://bugzilla.mozilla.org/show_bug.cgi?id=1622718 is being backed out which should resolve this.

Are we good to close this now?

Flags: needinfo?(agi)

Yep, thank you!

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(agi)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.