1626753 - WaveShaperNode.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

        return;
      } else {
        nullInput = true;
        channelCount = 1;
      }

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/dom/media/webaudio/WaveShaperNode.cpp#214-218

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Benoit CHAUVET]

Attachment: Bug 1626753 - WaveShaperNode.cpp : removed else after return. r?sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d05cb9cda4ed
WaveShaperNode.cpp : removed else after return. r=sylvestre

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d05cb9cda4ed