1626761 - nsBidiUtils.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

      // XXX do we really want to convert numerals when copying text?
      if (aPrevCharArabic) {
        if (aNumFlag == IBMBIDI_NUMERAL_PERSIANCONTEXT)
          return NUM_TO_PERSIAN(aChar);
        else
          return NUM_TO_HINDI(aChar);
      } else
        return NUM_TO_ARABIC(aChar);

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/intl/unicharutil/util/nsBidiUtils.cpp#57-63

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[bharath.bmsce]

Attachment: Bug 1626761 - Fixing readability-else-after-return bug, found by clang-tidy. r=jfkthame

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02618db5d8ca
Fixing readability-else-after-return bug, found by clang-tidy. r=jfkthame

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/02618db5d8ca