1626769 - BigIntType.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

      return BigInt::parseLiteralDigits(cx, Range<const CharT>(start, end), 10,
                                        isNegative, haveParseError);
    } else if (start[0] == '-') {
      bool isNegative = true;

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/js/src/vm/BigIntType.cpp#3530-3534

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[morganeckenroth]

Attachment: Bug 1626769 - Removed "else after return" code flow. r=Sylvestre

Comment 2

[morganeckenroth]

Hello, I am new to the Firefox software ecosystem, but have extensive experience with low-level embedded software development. I saw this bug and though it a good fit to get started learning the coded review and submission process. Please let me know if there is anything, or anyone, that I should add to the code patch that I submitted. Thank you in advance, and I am excited to start contributing! -Morgan

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7b063fef238
Removed "else after return" code flow. r=jandem

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b7b063fef238