1626784 - FPSCounter.cpp: the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

aHistogram.size() == 0
should use .empty() instead

https://searchfox.org/mozilla-central/source/gfx/layers/composite/FPSCounter.cpp#279

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[daltonsam437]

Attachment: Bug 1626784 - Changed FPSCounter.cpp to check for emptiness with .empty() instead of .size() r=jrmuizel

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:daltonsam437, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed0826f47244
Changed FPSCounter.cpp to check for emptiness with .empty() instead of .size() r=jrmuizel

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ed0826f47244