1626809 - disk-storage memory reporter does not properly anonymize

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

The reporter of bug 1626612 noticed that the cache memory reporter seems to include URLs even if the "anonymize" box is checked. The entries were like this (except with actual URLs instead of <some URL>):

5,841.42 MB (100.0%) -- explicit
├──4,754.89 MB (81.40%) -- network
│ ├──4,754.74 MB (81.40%) -- cache2
│ │ ├──3,012.85 MB (51.58%) ── disk-storage(O^userContextId=9&firstPartyDomain=<some URL>,)

Everything after disk-storage should probably be skipped of the report is anonymous.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

There's also some memory-storage entries that are similar.

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

The code is here:

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/netwerk/cache2/CacheStorageService.cpp#2273-2281

There's a comment that says "These key names are not privacy-sensitive." but that does not seem to be the case.

Comment 3

[Dragana Damjanovic [:dragana]]

Honza, can you take a look?

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Andrew McCreight [:mccr8] from comment #2)

The code is here:

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/netwerk/cache2/CacheStorageService.cpp#2273-2281

There's a comment that says "These key names are not privacy-sensitive." but that does not seem to be the case.

It's no longer truth, apparently. The easiest will probably be to not show the key at all. Showing a hash or an order number is not useful. Other option would be to do some kind of a regexp replace for URLs but it's not safe enough IMO.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: Bug 1626809 - Sanitize HTTP disk cache storage context key to prevent leak of private data like URLs, r=njn

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eba8610ac79b
Sanitize HTTP disk cache storage context key to prevent leak of private data like URLs, r=njn

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/eba8610ac79b