1626844 - Default font issues with Firefox in Georgian on macOS

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Francesco Lodolo [:flod]]

Attachment: Firefox #1

Issue reported by our Georgian localizer: Firefox sometimes falls back to Menlo (a monospace font).

MacOS Catalina uses Helvetica for Georgian, which also supports uppercase "Mtavruli" letters.

Is it possible to make Helvetica the default font for Georgian? Chrome seems to be using Helvetica consistently.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Firefox #2

Comment 2

[Francesco Lodolo [:flod]]

@Jonathan
Since you knows more about fonts than anyone else I'm aware of: any idea where this bug belongs, and if it can be fixed?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Jonathan Kew [:jfkthame]]

It looks like we'll get Helvetica if it appears explicitly in the font-family list, or if the generic sans-serif is used, but if not then we're hitting font fallback that uses Menlo as a default for the Unicode range that includes Georgian:

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/gfx/thebes/gfxPlatformMac.cpp#226-229

So the thing to do is to add Helvetica there ahead of Menlo, as a higher-priority default.

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1626844 - Prefer Helvetica over Menlo as fallback font for Georgian on macOS. r=lsalzman

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b3d4f3f430
Prefer Helvetica over Menlo as fallback font for Georgian on macOS. r=lsalzman

Comment 7

[Dorel Luca [:dluca]]

Backed out changeset b9b3d4f3f430 (bug 1626844) for WR failures in marker-text-matches-georgian.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295950593&repo=autoland&lineNumber=15862

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=295950593&revision=b9b3d4f3f43029957ede595ea2d723093dcbf48a

Backout:
https://hg.mozilla.org/integration/autoland/rev/3eef3763f676665997bb9ea349f555aeb0c1b432

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc1a253fc94b
Prefer Helvetica over Menlo as fallback font for Georgian on macOS. r=lsalzman

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dc1a253fc94b