Closed
Bug 1626873
Opened 5 years ago
Closed 5 years ago
xpcshell-test globals could be loaded from the testing/xpcshell/head.js file
Categories
(Developer Infrastructure :: Lint and Formatting, task, P2)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox77 fixed)
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
We should investigate getting tools/lint/eslint/eslint-plugin-mozilla/lib/configs/xpcshell-test.js
to load its globals directly from testing/xpcshell/head.js
.
We probably set it up in the early days when we didn't have the capability to load the globals from a file, but we should be able to do this now.
We should be able to do it because the browser-window
environment is formed the same way.
I'm also wondering if we shouldn't just create an xpcshell
environment and then have that turned on for xpcshell-tests and turn the browser environment off - I'm not sure if that will give us slightly better global definition for tests. It would be worth investigating.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 77.1 - Apr 6 - Apr 19
Points: --- → 3
Priority: -- → P2
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50e6ed17839e
Load xpcshell-test globals from the xpcshell head.js file rather than hard-code them. r=mossop
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•