Closed Bug 1626877 Opened 4 years ago Closed 4 years ago

test_location.js doesn't run fully

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Iteration:
77.1 - Apr 6 - Apr 19
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Bug 1626877 - test_location.js isn't running all its tests due to incorrect plaform detection. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review

I just noticed that test_location.js doesn't run fully. It is using Services.appinfo.OS which on xpcshell-tests is always XPCShell, as a result the final part of the test doesn't run.

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/toolkit/components/search/tests/xpcshell/test_location.js#30

Doing the obvious fix turns up test failures, so I need to have a look at what's happening there.

Iteration: 76.2 - Mar 23 - Apr 5 → 77.1 - Apr 6 - Apr 19
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/257217fbd516
test_location.js isn't running all its tests due to incorrect plaform detection. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/257217fbd516

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: