1626913 - "View Saved Logins" highlight is barely visible in the password autocomplete dropdown menu

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Peter Magyari (Desktop QA)]

Attachment: View Saved Logins Highlight

Affected Versions
All

Affected Platforms
Windows 10
MacOS 10.15

Steps to reproduce

1. Launch Firefox
2. Go to about:logins
3. Enter at least 2 logins for http://facebook.com and make sure to press "Save"
4. Navigate to http://facebook.com
5. Using the arrow down key reach "View Saved Logins" in order to highlight it in the autocomplete dropdown

Expected Result
The "View Saved Logins" selection is distinguishably highlighted

Actual Result
The highlight is barely visible

Comment 1

[Matthew N. [:MattN]]

We can't simply use the variables that change with dark mode since currently the rest of the autocomplete popup doesn't support it.

Comment 2

[Asa Dotzler [:asa]]

I see this issue elsewhere in the front end. The Show All [Bookmarks|Passwords|Downloads|Etc.] footer menu items are also hard to distinguish as focused because their focus color change is so minor (from gray to a nearby gray.)

IMO, we should either make the color change more prominent or we should have a focus outline like we do for the Clear Cookies and Site Data footer in the Site Identity panel.

MattN, I don't understand your comment about dark mode. In dark mode, these style of "footers" on menus are also really difficult to distinguish as focused.

Setting this as an access-p2 because the functionality works (you can arrow to it and activate it) but the focus indication is poor. I have good vision and I was barely able to distinguish the focused state. Users with certain kinds of low vision may not be able to see the focus at all. Unfortunately, I don't think this problem is limited to the password feature. I think it's a problem across our front end.

Comment 3

[Asa Dotzler [:asa]]

Updating the Accessibility Team's impact assessment to conform with the new triage guidelines. See https://wiki.mozilla.org/Accessibility/Triage for descriptions of these whiteboard flags.

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 5

[Tim Giles [:tgiles]]

I believe once bug 1697092 is implemented, we will be able to support light/dark themes in the autocomplete prompt and resolve this bug.