1626968 - Search engine list for Ja misses engines with Search Modernization on

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: 76r nightly loc-ja reg-us.jpg

[Environment:]

tested on:

• Windows 10

with:

• 76.0a1 20200402095145

[Steps to reproduce:]

1. Download and Install a Ja build.
2. Create a new profile and before starting it, set the region to Us by adding an user.js in the profile folder with the following line: user_pref("browser.search.region", "US");
3. Start the new profile.
4. Check the available search engines.
5. Switch browser.search.modernConfig to false
6. Restart Browser, check the available search engines.

[Actual result:]

4. Search displays 8 search engines with browser.search.modernConfig true.
5. Search displays 10 search engines with browser.search.modernConfig false.

[Expected result:]

Both with browser.search.modernConfig to true or false the number of expected engines, at least at the current date should be 10.

[Note:]

1. :standard8 hinted this is a typo in the configuration file: "The missing two engines have “jp” rather than “ja” (for the locale they’re deployed to)"
2. Switching on/off browser.search.modernConfig will keep the engines as described above: 8 for on and 10 for off.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Attachment: 74 release loc-ja reg-us.jpg

Comment 2

[Drew Willcoxon :adw]

This looks like it's a search bug and so belongs in Firefox::Search, but please correct me if I'm wrong.

Comment 3

[Mark Banner (:standard8)]

I have just fixed the typos (they were jp instead of ja) for rakuten and oshiete-goo search engines up for approval on stage/production, so they are now on the preview channels.

I've also run our automated tests against production preview and they pass

Adrian, your team should be able to test these now when you're ready.

Comment 4

[Mark Banner (:standard8)]

Just to note, that the testing should be against production-preview. We're currently use stage for other development.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Production Preview Search engine updates for the missing engines on ja look good for ja-jp and en.Us -jp using Ubuntu 18.04 and Windows 10.
We're gonna follow-up tomorrow with the Mac verification, but it makes no sense to me to block the publish on that alone: redirecting the NI for akw.

Comment 6

[Mark Banner (:standard8)]

Thanks, handing off to Mike to get it approved.

Comment 7

[Mark Banner (:standard8)]

Mike has now approved it, the update looks ok on searchengine-devtools.

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We can confirm the fix; we verified this issue on Ubuntu 18.04, macOS 10.13 and Windows 10 x64.
Marking the tracking flags accordingly.