Closed
Bug 1627131
Opened 5 years ago
Closed 5 years ago
Make xpcom/string buildable outside of a unified build environment
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
The instantiations of the externed templates need to be in the same translation unit as the definitions. Currently they work due to building in unified mode.
|
|
Assignee | |
Comment 3•5 years ago
|
||
kNotFound isn't actually defined in nsTStringRepr.h.
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29725bfd02d4
Part 1: Add missing includes to xpcom/string. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/57af1fdabe4c
Part 2: Move template function instantiations to definitions. r=xpcom-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/401a92dc4a37
Part 3: Move nsTString<T>::Contains implementation. r=xpcom-reviewers,sg
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/29725bfd02d4
https://hg.mozilla.org/mozilla-central/rev/57af1fdabe4c
https://hg.mozilla.org/mozilla-central/rev/401a92dc4a37
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
|
||
Updated•5 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•