Closed Bug 1627155 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 22671 - Revert "[shapedetection] Upstream TextDetection tests to WPT"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22671 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22671
Details from upstream follow.

Meredith Lane <meredithl@chromium.org> wrote:

Revert "[shapedetection] Upstream TextDetection tests to WPT"

This reverts commit a0d18c166ea4cd631e7b51cc0f5b6ec7d272f1d4.

Reason for revert: Deterministically fails on Mac10.10, first failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52676

Original change's description:

[shapedetection] Upstream TextDetection tests to WPT

This CL upstreams the reset of shapedetection tests(mainly
TextDetection tests) to WPT.

  • Moves tests under
    third_party/blink/web_tests/shapedetection/,
    third_party/blink/web_tests/fast/shapedetection/,
    third_party/blink/web_tests/http/tests/shapedetection/,
    to third_party/blink/web_tests/external/wpt/shape-detection.
  • Moves third_party/blink/web_tests/shapedetection/resources/mock-textdetection.js
    to third_party/blink/web_tests/external/wpt/resources/chromium/.
  • Removes third_party/blink/web_tests/fast/shapedetection/shapedetection-creation.html
    as which should be covered in idlharness tests.
  • Introduces simulateClosedPipe() to MockBarcodeDetectionProvider to simulate
    'no implementation available' case for
    third_party/blink/web_tests/external/wpt/shape-detection/detection-getSupportedFormats.https.html
  • Improves third_party/blink/web_tests/external/wpt/shape-detection/detection-options.https.html
    by using assert_throws_js BTW.

Bug: 932382
Change-Id: I2f795e4fa4f23b33c49b7924cdbcbccde5ac6ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131154
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Commit-Queue: Wanming Lin \<wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#756131}

TBR=reillyg@chromium.org,mcasas@chromium.org,wanming.lin@intel.com,foolip@chromium.org

Change-Id: Iabb63b96afc3f4eba5b3ba9708dd04296ccf86cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 932382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134030
Reviewed-by: Meredith Lane \<meredithl@chromium.org>
Commit-Queue: Meredith Lane \<meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756158}

PR 22671 applied with additional changes from upstream: 07ee1ff64a6dbb535efc4c7dce6030dc6e89a433
PR 22671 applied with additional changes from upstream: 07ee1ff64a6dbb535efc4c7dce6030dc6e89a433
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/954b62414f6c [wpt PR 22671] - Revert "[shapedetection] Upstream TextDetection tests to WPT", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.