1627185 - ContentBlockingController addException stopped working for private sessions

Status: RESOLVED INVALID

(GeckoView :: General, defect)

Description

[Manuel Martin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

This works flawlessly for regular sessions but it doesn't work for private sessions.
STRs:

• Open a private session
• Add a ContentBlockingController exception for that session.
• Get the stored exceptions via saveExceptionList or check a session via checkException

Actual results:

The exception hasn't been added

Expected results:

The exception should have been added

Comment 1

[Manuel Martin]

Seen in 76.0.20200330094747 but also in 76.0.20200402095145

Comment 2

[Randall Barker [:rbarker]]

This is a ship blocker for FxR.

Comment 3

[Randall Barker [:rbarker]]

Based on discussion, saveExceptionList() will not contain the private browsing session exceptions, however checkException should still work with a PB session.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1627185 - [1.0] Add a private mode content blocking exception test.

Comment 5

[Randall Barker [:rbarker]]

The issue was found to be that FxR was recreating the session when the exception list changed for private browsing sessions. Unfortunately the PB exception list is cleared when the last PB session gets closed so recreating the session was clearing the list when only on PB tab was open.

Comment 6

[Eugen Sawin [:esawin]]

Let's add the test in this bug anyways. The test is covering the general private mode exception use case.

Comment 7

[Chris Peterson [:cpeterson]]

Move GeckoView::Tracking Protection bugs to the GeckoView::General component.