Closed Bug 1627206 Opened 4 years ago Closed 4 years ago

HTTPS Only Mode - Upgrade failure telemetry

Categories

(Core :: DOM: Security, enhancement, P2)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: julianwels, Assigned: julianwels)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(2 files)

Bug 1627206 - Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb
47 bytes, text/x-phabricator-request
Details | Review
data-collection-request-1627206.txt
2.71 KB, text/plain
chutten
: data-review+
Details

Data collection to measure upgrade failures of the HTTPS Only Mode.

Telemetry questions:

  • How many requests fail after upgrade
    • Differentiation between top-level and sub-resource requests
    • Average timeout duration

Hi Chris,
just a heads up: The form is the same as in Bug 1620244, except for question 1 and 5 ^^

Attachment #9139498 - Flags: data-review?(chutten)
Comment on attachment 9139498 [details]
data-collection-request-1627206.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :ckersch and Julian Gaibler are responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+
Attachment #9139498 - Flags: data-review?(chutten) → data-review+
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f302c058d54
Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb,jcj,dragana

Also, there are bc perma failures at dom/security/test/https-only/browser_console_logging.js.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297907215&repo=autoland&lineNumber=33196

(In reply to Cristian Brindusan [:cbrindusan] from comment #6)

Also, there are bc perma failures at dom/security/test/https-only/browser_console_logging.js.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297907215&repo=autoland&lineNumber=33196

Thanks, I'll have a look at it!

Flags: needinfo?(julianwels)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/376986092fe4
Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb,jcj,dragana

Backed out changeset 376986092fe4 (bug 1627206) for causing browser_console_logging.js to fail
https://hg.mozilla.org/integration/autoland/rev/b8498a40239851aa3fd8d15561b3234b20aa975f

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&revision=376986092fe4e2d0199470fbedf13ca3ca35a8a8&selectedJob=297959408

log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297959408&repo=autoland&lineNumber=32424
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - TEST-PASS | dom/security/test/https-only/browser_console_logging.js | Sub-Resource upgrade for file_1 should get logged -
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://mochi.test:8888/file_2.jpg” to use “https”." {file: "http://mochi.test:8888/file_2.jpg" line: 0}]
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - TEST-PASS | dom/security/test/https-only/browser_console_logging.js | Sub-Resource upgrade for file_2 should get logged -
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/file_1.jpg” to use “https”." {file: "http://example.com/file_1.jpg" line: 0}]
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://mochi.test:8888/file_2.jpg” to use “https”." {file: "http://mochi.test:8888/file_2.jpg" line: 0}]
[task 2020-04-16T17:14:50.644Z] 17:14:50 INFO - Buffered messages finished
[task 2020-04-16T17:14:50.645Z] 17:14:50 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/https-only/browser_console_logging.js | Uncaught exception - undefined - timed out after 50 tries.
[task 2020-04-16T17:14:50.645Z] 17:14:50 INFO - Leaving test bound
[task 2020-04-16T17:14:50.645Z] 17:14:50 INFO - GECKO(7468) | MEMORY STAT | vsize 2104264MB | vsizeMaxContiguous 68145009MB | residentFast 272MB | heapAllocated 94MB
[task 2020-04-16T17:14:50.645Z] 17:14:50 INFO - TEST-OK | dom/security/test/https-only/browser_console_logging.js | took 5464ms
[task 2020-04-16T17:14:50.645Z] 17:14:50 INFO - GECKO(7468) | [Child 10032: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 000001917C796400 == 1 [pid = 10032] [id = {c6f9822b-3aad-42e0-82b3-8b083b3bc4a6}]
[task 2020-04-16T17:14:50.646Z] 17:14:50 INFO - GECKO(7468) | [Child 10032: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (000001917C7CE900) [pid = 10032] [serial = 1] [outer = 0000000000000000]
[task 2020-04-16T17:14:50.646Z] 17:14:50 INFO - GECKO(7468) | [Child 10032: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (000001917CB6D400) [pid = 10032] [serial = 2] [outer = 000001917C7CE900]
[task 2020-04-16T17:14:50.675Z] 17:14:50 INFO - checking window state
[task 2020-04-16T17:14:50.694Z] 17:14:50 INFO - GECKO(7468) | [Parent 3524, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsFrameLoader.cpp, line 695
[task 2020-04-16T17:14:50.696Z] 17:14:50 INFO - GECKO(7468) | [Parent 3524: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (0000015AA473A800) [pid = 3524] [serial = 14] [outer = 0000015AA6412040]
[task 2020-04-16T17:14:50.722Z] 17:14:50 INFO - GECKO(7468) | [Parent 3524: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (0000015AA473E800) [pid = 3524] [serial = 15] [outer = 0000015AA6412040]
[task 2020-04-16T17:14:50.862Z] 17:14:50 INFO - GECKO(7468) | [Child 8452: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0000020D4EDAF000) [pid = 8452] [serial = 2] [outer = 0000000000000000] [url = about:blank]
[task 2020-04-16T17:14:50.880Z] 17:14:50 INFO - GECKO(7468) | [Child 5248: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (000001D1630D3000) [pid = 5248] [serial = 5] [outer = 0000000000000000] [url = about:blank]
[task 2020-04-16T17:14:50.880Z] 17:14:50 INFO - GECKO(7468) | [Child 5248: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (000001D162BC2000) [pid = 5248] [serial = 2] [outer = 0000000000000000] [url = about:blank]

Flags: needinfo?(julianwels)

Oh, I'm sorry... I forgot about the perma failure again :(

Flags: needinfo?(julianwels)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c424381097d7
Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb,jcj,dragana
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2398d528159
Upgrade failure telemetry for HTTPS Only Mode. r=ckerschb,jcj,dragana

https://hg.mozilla.org/mozilla-central/rev/a2398d528159

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Flags: needinfo?(julianwels)
See Also: → 1868380
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: