Closed Bug 1627268 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22690 - Reland: [shapedetection] Upstream TextDetection tests to WPT

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22690 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22690
Details from upstream follow.

Wanming Lin <wanming.lin@intel.com> wrote:

Reland: [shapedetection] Upstream TextDetection tests to WPT

The original CL has been reverted because the test
external/wpt/shape-detection/idlharness.https.any.shareworker.html
is flaky on Mac. This reland CL disables this test on Mac.

Original change's description:

[shapedetection] Upstream TextDetection tests to WPT

This CL upstreams the reset of shapedetection tests(mainly
TextDetection tests) to WPT.

  • Moves tests under
    third_party/blink/web_tests/shapedetection/,
    third_party/blink/web_tests/fast/shapedetection/,
    third_party/blink/web_tests/http/tests/shapedetection/,
    to third_party/blink/web_tests/external/wpt/shape-detection.
  • Moves third_party/blink/web_tests/shapedetection/resources/mock-textdetection.js
    to third_party/blink/web_tests/external/wpt/resources/chromium/.
  • Removes third_party/blink/web_tests/fast/shapedetection/shapedetection-creation.html
    as which should be covered in idlharness tests.
  • Introduces simulateClosedPipe() to MockBarcodeDetectionProvider to simulate
    'no implementation available' case for
    third_party/blink/web_tests/external/wpt/shape-detection/detection-getSupportedFormats.https.html
  • Improves third_party/blink/web_tests/external/wpt/shape-detection/detection-options.https.html
    by using assert_throws_js BTW.

Bug: 932382
Change-Id: I2f795e4fa4f23b33c49b7924cdbcbccde5ac6ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131154
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Commit-Queue: Wanming Lin \<wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/master@{#756131}

Bug: 932382, 1067533
Change-Id: I85b5dcc841185e2edd20a76ed3aec8add7f08954

Reviewed-on: https://chromium-review.googlesource.com/2134924
WPT-Export-Revision: 0165a6164bf2b2d0cb52f826f0a38f1a3b4752fb

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8cf0741090a
[wpt PR 22690] - Reland: [shapedetection] Upstream TextDetection tests to WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/abd08f1ed642
[wpt PR 22690] - Update wpt metadata, a=testonly
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.