1627285 - DOMQuad and DOMRect should not use std::min/max for NaN-able doubles

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Timothy Gu [:TimothyGu]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.83 Safari/537.36

Steps to reproduce:

console.log(new DOMRect(0, 0, NaN, NaN).top);
console.log(new DOMRect(0, 0, NaN, NaN).left);
console.log(new DOMQuad({x: 0}, {x: 0}, {x: NaN}, {x: 0}).getBounds().x)

Actual results:

All three return 0.

Expected results:

After https://github.com/w3c/fxtf-drafts/pull/395, all three should return NaN. WPTs:

• https://github.com/web-platform-tests/wpt/blob/master/css/geometry/DOMRect-nan.html
• https://github.com/web-platform-tests/wpt/blob/master/css/geometry/DOMQuad-nan.html

Comment 1

[Timothy Gu [:TimothyGu]]

I could help fix this bug in

Comment 2

[Timothy Gu [:TimothyGu]]

Oops, pressed send too early. I'm creating a patch for this.

Comment 3

[Timothy Gu [:TimothyGu]]

Attachment: Bug 1627285 - Check for NaN before std::min/max() in DOMQuad and DOMRect. r=emilio,jwalden

Tests will be added as a part of bug 1626471. I have manually confirmed that
the added tests pass after this commit.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/791ce1643ae0
Check for NaN before std::min/max() in DOMQuad and DOMRect. r=emilio,jwalden

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/791ce1643ae0