1627336 - Avoid blocklist and signature checks on test extensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Andrew Swan [:aswan]]

Spinning off from bug 1625181 and related discussion on matrix, the mochitest framework sideloads the special-powers and mochitest extensions. As part of installing these during startup, the addon manager does things like blocklist and signature checks which confound existing tests that try to measure and minimize what's loaded during startup. In other words, those tests permit the blocklist, NSS, etc. to be loaded early in startup, even if that is only necessary for the test extensions and doesn't happen in a "normal" startup. There's a quick-and-dirty patch on bug 1625181 (that I'll move over here) to skip blocklist checks for the test extension, this bug is to look into extending that effort to signature checks and anything else that might apply.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1627336 Add Blocklist.jsm to browser_startup.js blacklist

Comment 2

[Andrew Swan [:aswan]]

Florian, it looks like the goal here should be to add additional blacklist entries to browser/base/content/test/performance/browser_startup.js, do you have suggestions for what could be added to ensure we're not loading NSS too early?
Also, bug 1362364 is relevant.

Comment 3

[Florian Quèze [:florian]]

(In reply to Andrew Swan [:aswan] from comment #2)

Florian, it looks like the goal here should be to add additional blacklist entries to browser/base/content/test/performance/browser_startup.js, do you have suggestions for what could be added to ensure we're not loading NSS too early?

https://hg.mozilla.org/try/rev/a3037824e64db000398c7466e9afaba86a1c3af1 is what we would add to ensure we don't initialize NSS too early. And it looks like it's already green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=472c2bc092ac37a32b18838877ad4901bfa7bd05

I ran browser_startup.js locally without and with your patch and saw no significant change in the components we load during the various phases. I guess the bug I remembered about loading mochitest add-ons triggering NSS init must have been fixed a long time ago. Sorry for the confusion :-(.

Comment 4

[Andrew Swan [:aswan]]

Paring this back, the test extensions are not sideloaded, they are installed via Marionette, that doesn't happen until some time after startup.
And the blocklist is already loaded shortly after startup: https://searchfox.org/mozilla-central/rev/41c3ea3ee8eab9ce7b82932257cb80b703cbba67/browser/components/BrowserGlue.jsm#2247
So, post bug bug 1625181 we're not loading the blocklist an earlier in tests than what happens in a normal (non-test) startup. But we can ensure that we don't load Blocklist.jsm any earlier than necessary, that's all the attached patch now does.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c680742a7917
Add Blocklist.jsm to browser_startup.js blacklist r=florian

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c680742a7917