1627337 - [Protections Dashboard 1.5] Lockwise card updates

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

The Lockwise card will require a number of updates reflected in this mock.
This includes string updates, new icons, removing the sync section, and adding a breached passwords section.

Comment 1

[Soumya Lahiri]

ewright: Hi, can I look into this issue? I'm fairly new to this, so I might need a few pointers along the way.

Comment 2

[:prathiksha]

(In reply to Soumya Lahiri from comment #1)

ewright: Hi, can I look into this issue? I'm fairly new to this, so I might need a few pointers along the way.

Sorry, I'm working on this. If you are interested, I can find other beginner bugs for you to work on :)

Comment 3

[Soumya Lahiri]

(In reply to :prathiksha from comment #2)

Sorry, I'm working on this. If you are interested, I can find other beginner bugs for you to work on :)
That would be really helpful.

Comment 4

[Soumya Lahiri]

(In reply to :prathiksha from comment #2)

Sorry, I'm working on this. If you are interested, I can find other beginner bugs for you to work on :)

That would be really helpful.

Comment 5

[:prathiksha]

Attachment: Bug 1627337 - Remove the connected devices label from the lockwise card. r?ewright

Comment 6

[:prathiksha]

Attachment: Bug 1627337 - Update lockwise card display and copy. r?ewright

Depends on D72693

Comment 7

[:prathiksha]

Attachment: Bug 1627337 - Remove breached logins lockwise section from the Monitor card. r?ewright

Comment 9

[:prathiksha]

Attachment: Data Review Request Form

Hi chutten, please let me know if there's anything else I can include in my request for data review. I'd like to note here that this is not a newly added probe. My patch adds extra information to an existing probe. The probe itself seems to have been added with this request: https://docs.google.com/document/d/1tgvT6v-JTIYibJeDTGEyiBlCf8SMYA3hI2VpPEETQ0k/edit#heading=h.e0m9zx28rnnf

Comment 10

[Chris H-C :chutten]

Comment on attachment 9145890 [details]
Data Review Request Form

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 80.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :prathiksha is responsible for renewing or removing the collection before it expires in Firefox 80.

---
Result: datareview+

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84a7a693caa9
Remove the connected devices label from the lockwise card. r=ewright,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/82ea79a8d71a
Update lockwise card display and copy. r=ewright,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/5c0ed7fff317
Remove breached logins lockwise section from the Monitor card. r=ewright,fluent-reviewers,flod

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/84a7a693caa9
https://hg.mozilla.org/mozilla-central/rev/82ea79a8d71a
https://hg.mozilla.org/mozilla-central/rev/5c0ed7fff317