1627340 - mach try chooser should exclude tasks defined in fuzzy.py's TARGET_TASK_FILTERS

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement)

Description

[Bob Clary [:bc] (inactive)]

TARGET_TASK_FILTERS in mozilla-central/tools/tryselect/selectors/fuzzy.py specifies tasks which should only be available to mach try fuzzy if --full is specified however it does not appear to be the case that mach try chooser respects these restrictions though I don't fully understand the issues.

When I start mach try chooser, select Test Suites then click Select All I get some android-hw tests, such as test-android-hw-p2-8-0-android-aarch64-qr/debug-geckoview-crashtest-e10s, though not all. I don't understand why this is so.

It would be very helpful to reduce unnecessary load on the android hardware if try chooser respected the TARGET_TASK_FILTERS and did not allow selection of android-hw tests unless --full was specified.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:ahal, I wonder if this is similar to bug 1627085, both are asking for the same solution, but have different places in code we want to use the same filters.

Comment 2

[Andrew Halberstadt [:ahal]]

Yeah, it is similar though not quite the same. We'll still need the logic to read this list independently in both tryselect and taskgraph.

I'd recommend solving this bug first by pulling the list and related logic out of fuzzy.py and into tasks.py. Then solve bug 1627085 after this one is done.

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

I'm looking to pick this up. I recall asking about applying filters to mach try chooser in the past, so this would be a good chance to implement what I thought have been present in the first place.

Comment 4

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1627340 - separate filter for try selectors and apply them to try chooser

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5907d661bb7
separate filter for try selectors and apply them to try chooser r=ahal,jmaher

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset c5907d661bb7 for causing lint failures in tryselect/selectors/chooser/init.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/ada71061c6fb56cb84936a77f00c6f481a56f74e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297065593&repo=autoland&lineNumber=289

Edwin, I believe this is the wrong diff that landed, right?

Comment 7

[Edwin Takahashi (:egao | infrequent contributor)]

Pushed a new revision for review.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ec68bf21d74
separate filter for try selectors and apply them to try chooser r=bc,ahal,jmaher

Comment 9

[Edwin Takahashi (:egao | infrequent contributor)]

I think after this lands, if there is interest it may be worthwhile to apply this same filter to the mach try syntax selector as well, since that's the one I notice still being used quite often where a ridiculous number of tests are being selected.

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4ec68bf21d74