1627354 - Upgrade Android compilerSdkVersion and build tools version to 29

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, task, P1)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1627354: Part 1 - Modify android-sdk.configure to use build tools 29.0.3; r=#build

• We change the SDK version to use build tools 29.0.3;
• We change build_tools_version from a list to a string;
• We convert android_build_tools to work correctly with the above change;
• We set the build tools version in configure, as gradle needs to access it
  in a subsequent patch.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1627354: Part 2 - Update gradle files to set buildToolsVersion; r=#build

Per https://developer.android.com/studio/releases/build-tools, the default
version of the build tools used is internal to the Gradle plugin for Android,
which in the current version of Gradle is 28. To use 29, we need to explicitly
specify that in .gradle files using buildToolsVersion.

We also change the specification of compileSdkVersion to obtain that
information from the build configuration.

Depends on D69631

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1627354: Part 3 - Update mozboot and wpt SDK dependencies; r=#build

Depends on D69632

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1627354: Part 4 - Update junit tests to reflect changes caused by the upgrade to platform 29; r=agi

Depends on D69633

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1627354: Part 5 - Update wrench to build using Android 29; r=kats

Depends on D69634

Comment 6

[Nick Alexander :nalexander [he/him]]

Thanks for wading through some hijinks, aklotz! Always pleased to see folks bump dependencies like this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/746913239a06
Part 1 - Modify android-sdk.configure to use build tools 29.0.3; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/e9582985649f
Part 2 - Update gradle files to set buildToolsVersion; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/292249884e46
Part 3 - Update mozboot and wpt SDK dependencies; r=jgraham,nalexander
https://hg.mozilla.org/integration/autoland/rev/1a93b70549c2
Part 4 - Update junit tests to reflect changes caused by the upgrade to platform 29; r=agi
https://hg.mozilla.org/integration/autoland/rev/c98499d204fb
Part 5 - Update wrench to build using Android 29; r=kats

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22729 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/746913239a06
https://hg.mozilla.org/mozilla-central/rev/e9582985649f
https://hg.mozilla.org/mozilla-central/rev/292249884e46
https://hg.mozilla.org/mozilla-central/rev/1a93b70549c2
https://hg.mozilla.org/mozilla-central/rev/c98499d204fb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot