BCE shouldn't have lineno and columno argument, and should instead use the associated FunctionBox::extent()
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
References
Details
Attachments
(2 files)
These two pieces of info should be redundant, so we should just use FunctionBox::extent.
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Outside of powering BytecodeSection's source notes generation, the line and
column numbers were almost entirely unused, except to power a single assertion
that lineno and column agreed between the stencil (BCE derived) and script.
However, by switching to using the SharedContext extents, we lose the ability
to always assert they're the same, because in the old system dynamically
allocated functions used externally provided column info that disagrees with
the parser result. In this patch the script still gets the same column
number as before, but we can't assert that the value is the same as what you
could get out of the BCE, because the BCE number is actually more accurate
than the script.
Fixing the script column should be followup.
Depends on D70410
Comment 4•5 years ago
|
||
Backed out 2 changesets (Bug 1627373) for causing wpt and mochitest-chrome failures
WPT failures
Failure log 1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297655223&repo=autoland&lineNumber=3684
Failure log 2: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297656547&repo=autoland&lineNumber=1984
Failure log 3: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297658778&repo=autoland&lineNumber=9640
Mochitest-chrome failures
Failure log 4: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297657400&repo=autoland&lineNumber=141251
Failure log 5: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297660215&repo=autoland&lineNumber=2283
Failure log 6: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297657950&repo=autoland&lineNumber=10306
Comment 5•5 years ago
|
||
Based on the failures, it looks like something is wrong with how Modules are handled.
Assignee | ||
Comment 6•5 years ago
|
||
Correct; This gave modules a line number of 1, ignoring the line and column of the options.
Corrected I think the remaining oranges on Try are intermittents:https://treeherder.mozilla.org/#/jobs?repo=try&revision=afcdd3de02e413d138386509fa5bb2d0875bd383
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e1c3f7241e4
https://hg.mozilla.org/mozilla-central/rev/f3d35a537298
Description
•