1627398 - Support frame tree dump in CSS pixels in layout debugger

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Sometimes it is easier to view rects and sizes in CSS pixels instead of app units in the frame tree dump. We can add an extra menu item like "Dump -> Frame (CSS pixels)" in layout debugger.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1627398 Part 1 - Convert nsIFrame::List flags to EnumSet.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1627398 Part 2 - Support printing frame tree in CSS pixels.

Audit all the types related to app units [1] printed in
nsIFrame::List (and all the methods that override it), and use
ConvertToString to convert their printing format to CSS pixels if
needed.

In addition, add operator<< to BaseCoord so that it can cooperate with
mozilla::ToString, which is needed by ConvertToString.

[1] The types include nsRect, nsSize, nscoord, LogicalRect, and
LogicalSize.

Depends on D69914

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1627398 Part 3 - Add a menu item in layout debugger to dump frames in CSS pixels.

Depends on D69915

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1627398 Part 4 - Remove nsIFrame::RootFrameList(), and simplify DumpFrameTree()'s implementation.

Depends on D69916

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1627398 Part 5 - Support dumping frame trees in CSS pixels for gdb and lldb.

Depends on D69917

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7025929aa093
Part 1 - Convert nsIFrame::List flags to EnumSet. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b02beca33eb1
Part 2 - Support printing frame tree in CSS pixels. r=heycam
https://hg.mozilla.org/integration/autoland/rev/31fb906085d3
Part 3 - Add a menu item in layout debugger to dump frames in CSS pixels. r=heycam
https://hg.mozilla.org/integration/autoland/rev/dfbf28046ce9
Part 4 - Remove nsIFrame::RootFrameList(), and simplify DumpFrameTree()'s implementation. r=heycam
https://hg.mozilla.org/integration/autoland/rev/be7a746a65e6
Part 5 - Support dumping frame trees in CSS pixels for gdb and lldb. r=heycam

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7025929aa093
https://hg.mozilla.org/mozilla-central/rev/b02beca33eb1
https://hg.mozilla.org/mozilla-central/rev/31fb906085d3
https://hg.mozilla.org/mozilla-central/rev/dfbf28046ce9
https://hg.mozilla.org/mozilla-central/rev/be7a746a65e6