1627469 - [Wayland] Don't use oversized surface sizes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

After Bug 1623060 we use widget size for wayland buffer size. But sometimes widget allocation is bigger than our lock area and causes rendering artifacts of popup windows. So we need to use lock area in that case.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

This seems to be caused by NativeMoveResizeWaylandPopupCallback() where the popup is resized over size requested by Firefox:

[Parent 29101: Main Thread]: D/Widget nsWindow::Show [0x7f37cad5d800] state 1
[Parent 29101: Main Thread]: D/Widget nsWindow::ConfigureWaylandPopupWindows [0x7f37cad5d800], frame 0x7f37d158e7e0 hasRemoteContent 0
[Parent 29101: Main Thread]: D/Widget [0x7f37cad5d800] popup node id=contentAreaContextMenu
[Parent 29101: Main Thread]: D/Widget [0x7f37cad5d800] is already configured.
[Parent 29101: Main Thread]: D/Widget moz_container_size_allocate [0x7f37d06a1a40] 0,0 -> 177 x 157
[Parent 29101: Main Thread]: D/WidgetWayland moz_container_move [0x7f37d06a1a40] 0,0
[Parent 29101: Main Thread]: D/Widget nsWindow::OnSizeAllocate [0x7f37cad5d800] 0,0 -> 177 x 157

[...]

[1295191.640] [e-mail](593, 820, 200, 200)
[Parent 29101: Main Thread]: D/Widget NativeMoveResizeWaylandPopupCallback [0x7f37cad5d800] flipped_x 0 flipped_y 0
[Parent 29101: Main Thread]: D/Widget flipped_rect x=619 y=892 width=200 height=200
[Parent 29101: Main Thread]: D/Widget final_rect x=619 y=843 width=200 height=200
[Parent 29101: Main Thread]: D/Widget orig mBounds x=1238 y=1784 width=354 height=314
[Parent 29101: Main Thread]: D/Widget new mBounds x=1238 y=1686 width=400 height=400
[Parent 29101: Main Thread]: D/Widget workarea for [0x7f37cad5d800], monitor 0x7f380d06b100: x0 y0 w3840 h2160
[1295191.742] [e-mail](544)
[1295191.771] -> [e-mail]_configure(544)
[1295191.923] -> [e-mail]_pool(new id wl_shm_pool@76, fd 137, 640000)
[1295191.961] -> [e-mail]_buffer(new id wl_buffer@81, 0, 400, 400, 1600, 0)
[1295192.282] -> [e-mail](wl_buffer@81, 0, 0)
[1295192.296] -> [e-mail]_buffer_scale(2)
[1295192.301] -> [e-mail](0, 0, 200, 200)
[1295192.313] -> [e-mail]_window_geometry(0, 0, 200, 200)
[1295192.325] -> [e-mail]_input_region(nil)
[1295192.349] -> [e-mail](new id wl_callback@82)
[1295192.358] -> [e-mail]()

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1627469 [Wayland] [Wayland] Don't use oversized wl_surface sizes, r?jhorak

• Calculate size of wl_buffer as an intersection of widget size and nsWindow bound size.
  We can't use wl_buffer bigger than nsWindow bound as it leads to rendering artifacts.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812b28276cbc
[Wayland] [Wayland] Don't use oversized wl_surface sizes, r=jhorak

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/812b28276cbc

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9138308 [details]
Bug 1627469 [Wayland] [Wayland] Don't use oversized wl_surface sizes, r?jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Visual glitches on popup windows.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Wayland only. Using gecko sized wl_surfaces instead of widget size should not cause any issue.
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9138308 [details]
Bug 1627469 [Wayland] [Wayland] Don't use oversized wl_surface sizes, r?jhorak

Fixes a Wayland-only bug. Approved for 76.0b2.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6885a158718