1627547 - Update WebPayments to call getRegion

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Comment 1

[Dale Harvey (:daleharvey)]

Hi Eden

I noticed your name in a lot of the history for PaymentRequest.cpp and figured you would be good to ping about this, if there is someone else you would prefer to ping please forward it on.

We are updating the way we do region fetching in firefox that webpayments currently uses in https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequest.cpp#79, are there any planned changes of behaviour or requests for this? I cant see this code using a pref observer which seems like it may lead to webpayments being unnecesarily disabled on new profile as browser.search.region will be empty on first load until the SearchService populates it

In In https://bugzilla.mozilla.org/show_bug.cgi?id=1627540 we plan on introducing an .idl so that webPayments can call Region.getRegion (WebPayments are the only consumers who need an .idl, other consumers are all JS)

Happy to hear any comments on the planned changes
Cheers

Comment 2

[Eden Chuang[:edenchuang]]

Hello Dale. Thank you for the information

We have no plan to changing the WebPayment's implementation currently.
Now WebPayment is disabled, so just go ahead, don't worry about any impact on it.
I have no comment on idl service idea, it is good enough for PaymentRequest.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1627547 - Switch WebPayments to use nsIRegion.idl interface

Depends on D79914

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ced4f1895f7d
Switch WebPayments to use nsIRegion.idl interface r=edenchuang

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ced4f1895f7d