Closed Bug 1627547 Opened 1 year ago Closed 1 year ago

Update WebPayments to call getRegion

Categories

(Firefox :: Search, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 80
Iteration:
81.1 - July 27 - Aug 09
Tracking Status
firefox80 --- fixed

People

(Reporter: daleharvey, Assigned: daleharvey)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Priority: -- → P3
Points: --- → 2

Hi Eden

I noticed your name in a lot of the history for PaymentRequest.cpp and figured you would be good to ping about this, if there is someone else you would prefer to ping please forward it on.

We are updating the way we do region fetching in firefox that webpayments currently uses in https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequest.cpp#79, are there any planned changes of behaviour or requests for this? I cant see this code using a pref observer which seems like it may lead to webpayments being unnecesarily disabled on new profile as browser.search.region will be empty on first load until the SearchService populates it

In In https://bugzilla.mozilla.org/show_bug.cgi?id=1627540 we plan on introducing an .idl so that webPayments can call Region.getRegion (WebPayments are the only consumers who need an .idl, other consumers are all JS)

Happy to hear any comments on the planned changes
Cheers

Flags: needinfo?(echuang)

Hello Dale. Thank you for the information

We have no plan to changing the WebPayment's implementation currently.
Now WebPayment is disabled, so just go ahead, don't worry about any impact on it.
I have no comment on idl service idea, it is good enough for PaymentRequest.

Flags: needinfo?(echuang)
Assignee: nobody → dharvey
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ced4f1895f7d
Switch WebPayments to use nsIRegion.idl interface r=edenchuang
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
Iteration: --- → 81.1 - July 27 - Aug 09
You need to log in before you can comment on or make changes to this bug.